Re: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Andrew Morton
On Wed, 9 May 2007 16:10:05 -0700 "Yu, Fenghua" <[EMAIL PROTECTED]> wrote: > > > On Wed, 9 May 2007, Andrew Morton wrote: > > >> erm, it's not obviosu from all this that the patches are worth > proceeding > >> with, are they? > > >What was it? 0.5% performance improvement on a synthetic benchm

RE: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Yu, Fenghua
On Wed, 9 May 2007, Andrew Morton wrote: >> erm, it's not obviosu from all this that the patches are worth proceeding >> with, are they? >What was it? 0.5% performance improvement on a synthetic benchmark? >Process wakeup I believe? The initial patch and discussion is from: http://www.uwsg.iu

Re: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Siddha, Suresh B
On Wed, May 09, 2007 at 03:56:57PM -0700, Christoph Lameter wrote: > On Wed, 9 May 2007, Andrew Morton wrote: > > erm, it's not obviosu from all this that the patches are worth proceeding > > with, are they? Andrew, There are two advantages with this patch. 1. Space savings.. For me, I really do

Re: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Christoph Lameter
On Wed, 9 May 2007, Andrew Morton wrote: > erm, it's not obviosu from all this that the patches are worth proceeding > with, are they? What was it? 0.5% performance improvement on a synthetic benchmark? Process wakeup I believe? - To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Andrew Morton
On Wed, 9 May 2007 15:16:11 -0700 "Yu, Fenghua" <[EMAIL PROTECTED]> wrote: > > >hm, DEFINE_PER_CPU_SHARED_CACHELINE_ALIGNED is a bit of a mouthful. > > >I wonder if we can improve things here so that we use the > runtime-detected > >cacheline size rather than the compile-time size. I guess not,

RE: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Yu, Fenghua
>hm, DEFINE_PER_CPU_SHARED_CACHELINE_ALIGNED is a bit of a mouthful. >I wonder if we can improve things here so that we use the runtime-detected >cacheline size rather than the compile-time size. I guess not, given that >the offsets into the percpu area are calculated at build-time. >Did you wo

Re: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-09 Thread Andrew Morton
On Mon, 7 May 2007 15:59:44 -0700 Fenghua Yu <[EMAIL PROTECTED]> wrote: > On Fri, May 04, 2007 at 05:12:31PM -0700, Fenghua Yu wrote: > > > > Call percpu smp cacheline align interface. > > > > This is updated patch. Use new macro name > DEFINE_PER_CPU_SHARED_CACHELINE_ALIGNED for better code u

Re: [PATCH 2/2] Call percpu smp cacheline algin interface

2007-05-07 Thread Fenghua Yu
On Fri, May 04, 2007 at 05:12:31PM -0700, Fenghua Yu wrote: > > Call percpu smp cacheline align interface. > This is updated patch. Use new macro name DEFINE_PER_CPU_SHARED_CACHELINE_ALIGNED for better code understanding. Signed-off-by: Fenghua Yu <[EMAIL PROTECTED]> Acked-by: Suresh Siddha <[