Re: [PATCH 183/196] driver core: fix build with SYSFS=n

2008-01-25 Thread Harvey Harrison
On Sat, 2008-01-26 at 00:18 +0100, Ingo Molnar wrote: > * Greg KH <[EMAIL PROTECTED]> wrote: > > > > Please! :-) > > > > Yes, I do agree that this is important, I'll work to not let this > > happen again. Especially now that I have your build scripts, I'm > > working on setting up something li

Re: [PATCH 183/196] driver core: fix build with SYSFS=n

2008-01-25 Thread Ingo Molnar
* Greg KH <[EMAIL PROTECTED]> wrote: > > Please! :-) > > Yes, I do agree that this is important, I'll work to not let this > happen again. Especially now that I have your build scripts, I'm > working on setting up something like that myself here. btw., Harvey Harrison has cleaned them up som

Re: [PATCH 183/196] driver core: fix build with SYSFS=n

2008-01-25 Thread Greg KH
On Fri, Jan 25, 2008 at 11:57:23PM +0100, Ingo Molnar wrote: > > * Greg KH <[EMAIL PROTECTED]> wrote: > > > > Changes like this (and it now leaked into Linus' tree as well) kill > > > bisectability. > > > > The odds that a "normal" person has sysfs turned off and modules > > enabled, trying to

Re: [PATCH 183/196] driver core: fix build with SYSFS=n

2008-01-25 Thread Ingo Molnar
* Greg KH <[EMAIL PROTECTED]> wrote: > > Changes like this (and it now leaked into Linus' tree as well) kill > > bisectability. > > The odds that a "normal" person has sysfs turned off and modules > enabled, trying to bisect things, is pretty slim :) that "slim" combination is what i use for

Re: [PATCH 183/196] driver core: fix build with SYSFS=n

2008-01-25 Thread Greg KH
On Fri, Jan 25, 2008 at 11:25:30PM +0100, Ingo Molnar wrote: > > * Greg Kroah-Hartman <[EMAIL PROTECTED]> wrote: > > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > When SYSFS=n and MODULES=y, build ends with: > > > > linux-2.6.24-rc6-mm1/drivers/base/module.c: In function 'module_add_driver':

Re: [PATCH 183/196] driver core: fix build with SYSFS=n

2008-01-25 Thread Andrew Morton
> On Fri, 25 Jan 2008 23:25:30 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Greg Kroah-Hartman <[EMAIL PROTECTED]> wrote: > > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > When SYSFS=n and MODULES=y, build ends with: > > > > linux-2.6.24-rc6-mm1/drivers/base/module.c: In function 'modu

Re: [PATCH 183/196] driver core: fix build with SYSFS=n

2008-01-25 Thread Ingo Molnar
* Greg Kroah-Hartman <[EMAIL PROTECTED]> wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > When SYSFS=n and MODULES=y, build ends with: > > linux-2.6.24-rc6-mm1/drivers/base/module.c: In function 'module_add_driver': > linux-2.6.24-rc6-mm1/drivers/base/module.c:49: error: 'module_kset' > und