Re: [PATCH 18/33] power: supply: use match_string() helper

2018-05-22 Thread Sebastian Reichel
Hi Andy, On Tue, May 22, 2018 at 12:58:14AM +0300, Andy Shevchenko wrote: > On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: > > match_string() returns the index of an array for a matching string, > > which can be used intead of open coded variant. > > > > This doesn't make code looks better

Re: [PATCH 18/33] power: supply: use match_string() helper

2018-05-21 Thread Andy Shevchenko
On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie wrote: > match_string() returns the index of an array for a matching string, > which can be used intead of open coded variant. > This doesn't make code looks better anyhow. I even think it makes it worse to read. That's why I dropped my version of the