Re: [PATCH 18/22] m68k/mm: kmap - Modernize printing of kernel messages

2016-12-09 Thread Finn Thain
On Thu, 8 Dec 2016, I wrote: > > On Wed, 7 Dec 2016, Geert Uytterhoeven wrote: > > > - Convert from printk() to pr_*(), > > - Add missing continuations, > > - Remove #undef DEBUG. > > > > Note that "#ifdef DEBUG" is sometimes retained because pr_cont() is > > not optimized away when deb

Re: [PATCH 18/22] m68k/mm: kmap - Modernize printing of kernel messages

2016-12-07 Thread Finn Thain
On Wed, 7 Dec 2016, Geert Uytterhoeven wrote: > - Convert from printk() to pr_*(), > - Add missing continuations, > - Remove #undef DEBUG. > > Note that "#ifdef DEBUG" is sometimes retained because pr_cont() is not > optimized away when debugging is disabled. > I think that argues for us