Re: [PATCH 17/20] misc: genwqe: card_base: Do not pass unused argument 'fatal_err'

On Tue, 30 Jun 2020, haver wrote: > On 2020-06-30 11:10, Lee Jones wrote: > > On Tue, 30 Jun 2020, haver wrote: > > > > > On 2020-06-29 16:04, Lee Jones wrote: > > > > 'fatal_err' is taken as an argument to a static function which is only > > > > invoked once. During this invocation 'fatal_err'

Re: [PATCH 17/20] misc: genwqe: card_base: Do not pass unused argument 'fatal_err'

On 2020-06-30 11:10, Lee Jones wrote: On Tue, 30 Jun 2020, haver wrote: On 2020-06-29 16:04, Lee Jones wrote: > 'fatal_err' is taken as an argument to a static function which is only > invoked once. During this invocation 'fatal_err' is not set. There > doesn't appear to be a good reason to k

Re: [PATCH 17/20] misc: genwqe: card_base: Do not pass unused argument 'fatal_err'

On Tue, 30 Jun 2020, haver wrote: > On 2020-06-29 16:04, Lee Jones wrote: > > 'fatal_err' is taken as an argument to a static function which is only > > invoked once. During this invocation 'fatal_err' is not set. There > > doesn't appear to be a good reason to keep it around. > > > > Also fixe

Re: [PATCH 17/20] misc: genwqe: card_base: Do not pass unused argument 'fatal_err'

On 2020-06-29 16:04, Lee Jones wrote: 'fatal_err' is taken as an argument to a static function which is only invoked once. During this invocation 'fatal_err' is not set. There doesn't appear to be a good reason to keep it around. Also fixes the following W=1 kernel build warning: drivers/mis