Re: [PATCH 16/21] sysfs: implement bin_buffer

2007-05-02 Thread Tejun Heo
Satyam Sharma wrote: >> Yes, I saw that, but you could change it just as well. In any case, >> this will only make fs/sysfs/bin.c similar to what is being done in >> fs/sysfs/file.c. We allocate the buffer page backing the attribute's >> data in fill_read_buffer() and fill_write_buffer() using >> g

Re: [PATCH 16/21] sysfs: implement bin_buffer

2007-05-01 Thread Satyam Sharma
On 5/2/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: (We went off-list just now. Adding lkml again.) On 5/1/07, Tejun Heo <[EMAIL PROTECTED]> wrote: > Satyam Sharma wrote: > > On 4/28/07, Tejun Heo <[EMAIL PROTECTED]> wrote: > >> Implement bin_buffer which contains a mutex and pointer to PAGE_SIZ

Re: [PATCH 16/21] sysfs: implement bin_buffer

2007-05-01 Thread Satyam Sharma
(We went off-list just now. Adding lkml again.) On 5/1/07, Tejun Heo <[EMAIL PROTECTED]> wrote: Satyam Sharma wrote: > On 4/28/07, Tejun Heo <[EMAIL PROTECTED]> wrote: >> Implement bin_buffer which contains a mutex and pointer to PAGE_SIZE >> buffer to properly synchronize accesses to per-openfi

Re: [PATCH 16/21] sysfs: implement bin_buffer

2007-05-01 Thread Satyam Sharma
On 4/28/07, Tejun Heo <[EMAIL PROTECTED]> wrote: Implement bin_buffer which contains a mutex and pointer to PAGE_SIZE buffer to properly synchronize accesses to per-openfile buffer and prepare for immediate-kobj-disconnect. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- [...] @@ -135,14 +160,2