Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-28 Thread J. Bruce Fields
On Sat, Jan 26, 2013 at 01:34:56PM +, Arnd Bergmann wrote: > On Saturday 26 January 2013, Russell King - ARM Linux wrote: > > On Fri, Jan 25, 2013 at 11:45:25PM +, Arnd Bergmann wrote: > > > On Friday 25 January 2013, Myklebust, Trond wrote: > > > > > -Original Message- > > > > > Fr

Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-26 Thread Arnd Bergmann
On Saturday 26 January 2013, Russell King - ARM Linux wrote: > On Fri, Jan 25, 2013 at 11:45:25PM +, Arnd Bergmann wrote: > > On Friday 25 January 2013, Myklebust, Trond wrote: > > > > -Original Message- > > > > From: Arnd Bergmann [mailto:a...@arndb.de] > > > > Marking it as __maybe_un

Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-26 Thread Russell King - ARM Linux
On Fri, Jan 25, 2013 at 11:45:25PM +, Arnd Bergmann wrote: > On Friday 25 January 2013, Myklebust, Trond wrote: > > > -Original Message- > > > From: Arnd Bergmann [mailto:a...@arndb.de] > > > Marking it as __maybe_unused avoids a harmless gcc warning. > > > > Alternatively, just declar

Re: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-25 Thread Arnd Bergmann
On Friday 25 January 2013, Myklebust, Trond wrote: > > -Original Message- > > From: Arnd Bergmann [mailto:a...@arndb.de] > > Marking it as __maybe_unused avoids a harmless gcc warning. > > Alternatively, just declare it using the RPC_IFDEBUG() macro. Right, makes sense: that's more consis

RE: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-25 Thread Myklebust, Trond
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Friday, January 25, 2013 5:44 PM > To: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org; Arnd Bergmann; J. Bruce Fields; > Myklebust, Trond; linux-...@vger.kernel.org; net...@vger.kernel.org > S