Re: [PATCH 14/22] ncr5380: Add MAX_LUN limit

2016-03-15 Thread Christoph Hellwig
On Tue, Mar 15, 2016 at 02:20:55PM +1100, Finn Thain wrote: > I don't think the host template is the right place for this (there are > about ten of these that would need to be changed anyway) because > scsi_host_alloc() assigns shost->max_lun = 8. So I'll add the > instance->max_lun = 7 assignme

Re: [PATCH 14/22] ncr5380: Add MAX_LUN limit

2016-03-14 Thread Finn Thain
On Mon, 14 Mar 2016, Christoph Hellwig wrote: > On Mon, Mar 14, 2016 at 03:27:14PM +1100, Finn Thain wrote: > > The driver has a limit of eight LUs because of the byte-sized bitfield > > that is used for busy flags. Reject commands with LUN > 7. > > Please just set the max_lun parameter in the h

Re: [PATCH 14/22] ncr5380: Add MAX_LUN limit

2016-03-14 Thread Christoph Hellwig
On Mon, Mar 14, 2016 at 03:27:14PM +1100, Finn Thain wrote: > The driver has a limit of eight LUs because of the byte-sized bitfield > that is used for busy flags. Reject commands with LUN > 7. Please just set the max_lun parameter in the host template, which will take care of this.

Re: [PATCH 14/22] ncr5380: Add MAX_LUN limit

2016-03-14 Thread Hannes Reinecke
On 03/14/2016 05:27 AM, Finn Thain wrote: > The driver has a limit of eight LUs because of the byte-sized bitfield > that is used for busy flags. Reject commands with LUN > 7. > > Signed-off-by: Finn Thain > > --- > drivers/scsi/NCR5380.c |6 ++ > drivers/scsi/NCR5380.h |2 ++ > 2 f