Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-28 Thread Tony Lindgren
* Aaro Koskinen [190828 18:23]: > On Wed, Aug 28, 2019 at 03:02:36PM +0200, Arnd Bergmann wrote: > > I assume you checked that the uart output wasn't already broken > > by one of the earlier patches, right? > > Correct, it's only with the mapping change patch it hangs. > > > Also, looking at arc

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-28 Thread Aaro Koskinen
Hi, On Wed, Aug 28, 2019 at 03:02:36PM +0200, Arnd Bergmann wrote: > On Tue, Aug 27, 2019 at 9:05 PM Aaro Koskinen wrote: > > On Tue, Aug 27, 2019 at 06:33:01PM +0200, Arnd Bergmann wrote: > > > On Fri, Aug 16, 2019 at 10:34 AM Aaro Koskinen > > > wrote: > > > > However with earlyprintk it seem

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-28 Thread Arnd Bergmann
On Tue, Aug 27, 2019 at 9:05 PM Aaro Koskinen wrote: > On Tue, Aug 27, 2019 at 06:33:01PM +0200, Arnd Bergmann wrote: > > On Fri, Aug 16, 2019 at 10:34 AM Aaro Koskinen wrote: > > > However with earlyprintk it seems to hang as soon as kernel tries to print > > > something. So something goes wrong

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-27 Thread Aaro Koskinen
Hi, On Tue, Aug 27, 2019 at 06:33:01PM +0200, Arnd Bergmann wrote: > On Fri, Aug 16, 2019 at 10:34 AM Aaro Koskinen wrote: > > On Wed, Aug 14, 2019 at 12:36:40PM +0200, Arnd Bergmann wrote: > > > On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > > > > * Arnd Bergmann [190813 19:34]: > > >

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-27 Thread Arnd Bergmann
On Fri, Aug 16, 2019 at 10:34 AM Aaro Koskinen wrote: > On Wed, Aug 14, 2019 at 12:36:40PM +0200, Arnd Bergmann wrote: > > On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > > > * Arnd Bergmann [190813 19:34]: > > > > -#define OMAP1_IO_OFFSET0x0100 /* Virtual IO > >

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-16 Thread Aaro Koskinen
Hi, On Wed, Aug 14, 2019 at 12:36:40PM +0200, Arnd Bergmann wrote: > On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > > * Arnd Bergmann [190813 19:34]: > > > -#define OMAP1_IO_OFFSET0x0100 /* Virtual IO > > > = 0xfefb */ > > > +#define OMAP1_IO_OFFSET

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-14 Thread Tony Lindgren
* Arnd Bergmann [190814 10:37]: > On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > > * Arnd Bergmann [190813 19:34]: > > > On Tue, Aug 13, 2019 at 8:12 PM Aaro Koskinen > > > wrote: > > > diff --git a/arch/arm/mach-omap1/hardware.h > > > b/arch/arm/mach-omap1/hardware.h > > > index 232b

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-14 Thread Arnd Bergmann
On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > * Arnd Bergmann [190813 19:34]: > > On Tue, Aug 13, 2019 at 8:12 PM Aaro Koskinen wrote: > > diff --git a/arch/arm/mach-omap1/hardware.h b/arch/arm/mach-omap1/hardware.h > > index 232b8deef907..9fc76a3c9e57 100644 > > --- a/arch/arm/mach-oma

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-14 Thread Tony Lindgren
* Arnd Bergmann [190813 19:34]: > On Tue, Aug 13, 2019 at 8:12 PM Aaro Koskinen wrote: > > On Tue, Aug 13, 2019 at 01:02:16PM +0200, Arnd Bergmann wrote: > > > On Tue, Aug 13, 2019 at 12:36 PM Tony Lindgren wrote: > > > > > - I force CONFIG_PCI to be enabled here in order to keep the > > > asm

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-13 Thread Arnd Bergmann
On Tue, Aug 13, 2019 at 8:12 PM Aaro Koskinen wrote: > On Tue, Aug 13, 2019 at 01:02:16PM +0200, Arnd Bergmann wrote: > > On Tue, Aug 13, 2019 at 12:36 PM Tony Lindgren wrote: > > > - I force CONFIG_PCI to be enabled here in order to keep the > > asm/io.h logic unchanged. If PCI support in itse

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-13 Thread Aaro Koskinen
Hi, On Tue, Aug 13, 2019 at 01:02:16PM +0200, Arnd Bergmann wrote: > On Tue, Aug 13, 2019 at 12:36 PM Tony Lindgren wrote: > > * Arnd Bergmann [190808 21:34]: > > > The ISA I/O space handling in omap_cf is incompatible with > > > PCI drivers in a multiplatform kernel, and requires a custom > > >

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-13 Thread Arnd Bergmann
On Tue, Aug 13, 2019 at 12:36 PM Tony Lindgren wrote: > * Arnd Bergmann [190808 21:34]: > > The ISA I/O space handling in omap_cf is incompatible with > > PCI drivers in a multiplatform kernel, and requires a custom > > mach/io.h. > > > > Change the driver to use pci_ioremap_io() like PCI driver

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-13 Thread Tony Lindgren
Hi, * Arnd Bergmann [190808 21:34]: > The ISA I/O space handling in omap_cf is incompatible with > PCI drivers in a multiplatform kernel, and requires a custom > mach/io.h. > > Change the driver to use pci_ioremap_io() like PCI drivers do, > so the generic ioport access can work across platforms