Re: [PATCH 13/28] mm, page_alloc: Remove redundant check for empty zonelist

2016-04-26 Thread Andrew Morton
On Tue, 26 Apr 2016 14:00:11 +0100 Mel Gorman wrote: > If Andrew is watching, please drop this patch if possible. Thud.

Re: [PATCH 13/28] mm, page_alloc: Remove redundant check for empty zonelist

2016-04-26 Thread Mel Gorman
On Tue, Apr 26, 2016 at 02:04:51PM +0200, Vlastimil Babka wrote: > On 04/15/2016 11:07 AM, Mel Gorman wrote: > >A check is made for an empty zonelist early in the page allocator fast path > >but it's unnecessary. When get_page_from_freelist() is called, it'll return > >NULL immediately. Removing th

Re: [PATCH 13/28] mm, page_alloc: Remove redundant check for empty zonelist

2016-04-26 Thread Vlastimil Babka
On 04/15/2016 11:07 AM, Mel Gorman wrote: A check is made for an empty zonelist early in the page allocator fast path but it's unnecessary. When get_page_from_freelist() is called, it'll return NULL immediately. Removing the first check is slower for machines with memoryless nodes but that is a c