Re: [PATCH 13/25] aio: Convert read_events() to hrtimers

2012-11-28 Thread Kent Overstreet
On Wed, Nov 28, 2012 at 04:24:36PM -0800, Zach Brown wrote: > > - int i = 0; > > + DEFINE_WAIT(wait); > > + struct hrtimer_sleeper t; > > + size_t i = 0; > > Changing i to size_t is kind of surprising. Is that on purpose? I doubt it matters due to limits on ringbuffer

Re: [PATCH 13/25] aio: Convert read_events() to hrtimers

2012-11-28 Thread Zach Brown
> - int i = 0; > + DEFINE_WAIT(wait); > + struct hrtimer_sleeper t; > + size_t i = 0; Changing i to size_t is kind of surprising. Is that on purpose? > - set_task_state(tsk, TASK_RUNNING); > - remove_wait_queue(&ctx->wait, &wait); > - >