Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-26 Thread Nick Desaulniers
On Sat, Aug 24, 2019 at 5:48 AM Miguel Ojeda wrote: > > On Sat, Aug 24, 2019 at 1:25 PM Will Deacon wrote: > > > > Which bit are you pinging about? This patch (12/16) has been in -next for a > > while and is queued in the arm64 tree for 5.4. The Oops/boot issue is > > addressed in patch 14 which

Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-24 Thread Miguel Ojeda
On Sat, Aug 24, 2019 at 1:25 PM Will Deacon wrote: > > Which bit are you pinging about? This patch (12/16) has been in -next for a > while and is queued in the arm64 tree for 5.4. The Oops/boot issue is > addressed in patch 14 which probably needs to be sent as a separate patch > (with a commit me

Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-24 Thread Will Deacon
On Fri, Aug 23, 2019 at 09:35:08PM +0200, Miguel Ojeda wrote: > On Thu, Aug 15, 2019 at 11:12 AM Miguel Ojeda > wrote: > > > > Btw, I guess that is the Oops you were mentioning in the cover letter? > > Pinging about this... Which bit are you pinging about? This patch (12/16) has been in -next fo

Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-23 Thread Miguel Ojeda
On Thu, Aug 15, 2019 at 11:12 AM Miguel Ojeda wrote: > > Btw, I guess that is the Oops you were mentioning in the cover letter? Pinging about this... Cheers, Miguel

Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-15 Thread Miguel Ojeda
On Thu, Aug 15, 2019 at 11:08 AM Miguel Ojeda wrote: > > On Thu, Aug 15, 2019 at 12:20 AM Nick Desaulniers > wrote: > > > > This lone patch of the series is just cosmetic, but patch 14/16 fixes > > a real boot issue: > > https://github.com/ClangBuiltLinux/linux/issues/619 > > Miguel, I'd like to

Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-15 Thread Miguel Ojeda
On Thu, Aug 15, 2019 at 12:20 AM Nick Desaulniers wrote: > > This lone patch of the series is just cosmetic, but patch 14/16 fixes > a real boot issue: > https://github.com/ClangBuiltLinux/linux/issues/619 > Miguel, I'd like to get that one landed ASAP; the rest are just for > consistency. Ah, i

Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-14 Thread Nick Desaulniers
On Tue, Aug 13, 2019 at 10:08 AM Will Deacon wrote: > > On Tue, Aug 13, 2019 at 02:36:06PM +0200, Miguel Ojeda wrote: > > On Tue, Aug 13, 2019 at 10:27 AM Will Deacon wrote: > > > On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote: > > > > GCC unescapes escaped string section names

Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-13 Thread Will Deacon
On Tue, Aug 13, 2019 at 02:36:06PM +0200, Miguel Ojeda wrote: > On Tue, Aug 13, 2019 at 10:27 AM Will Deacon wrote: > > On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote: > > > GCC unescapes escaped string section names while Clang does not. Because > > > __section uses the `#` stri

Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-13 Thread Miguel Ojeda
On Tue, Aug 13, 2019 at 10:27 AM Will Deacon wrote: > > Hi Nick, > > On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote: > > GCC unescapes escaped string section names while Clang does not. Because > > __section uses the `#` stringification operator for the section name, it > > doesn

Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-13 Thread Will Deacon
Hi Nick, On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote: > GCC unescapes escaped string section names while Clang does not. Because > __section uses the `#` stringification operator for the section name, it > doesn't need to be escaped. > > This antipattern was found with: > $ g