Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-09 Thread Joe Perches
On Fri, 2018-03-09 at 07:44 +, Ard Biesheuvel wrote: > On 9 March 2018 at 07:43, Ard Biesheuvel wrote: > > On 8 March 2018 at 11:05, Joe Perches wrote: > > > On Thu, 2018-03-08 at 08:00 +, Ard Biesheuvel wrote: > > > > From: Colin Ian King > > > > > > > > Don't populate the const read-o

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-09 Thread Ard Biesheuvel
Hi Lukas, On 9 March 2018 at 08:29, Lukas Wunner wrote: > On Fri, Mar 09, 2018 at 08:47:19AM +0100, Ingo Molnar wrote: >> * Ard Biesheuvel wrote: >> > From: Colin Ian King >> > >> > Don't populate the const read-only array 'buf' on the stack but instead >> > make it static. Makes the object cod

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-09 Thread Ingo Molnar
* Ard Biesheuvel wrote: > On 9 March 2018 at 08:04, Ingo Molnar wrote: > > > > * Ard Biesheuvel wrote: > > > >> > Also, would it make sense to rename it to something more descriptive like > >> > "apple_unicode_str[]" or so? > >> > > >> > Plus an unicode string literal initializer would be pret

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-09 Thread Lukas Wunner
On Fri, Mar 09, 2018 at 08:47:19AM +0100, Ingo Molnar wrote: > * Ard Biesheuvel wrote: > > From: Colin Ian King > > > > Don't populate the const read-only array 'buf' on the stack but instead > > make it static. Makes the object code smaller by 64 bytes: > > > > Before: > >textdata

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-09 Thread Ard Biesheuvel
On 9 March 2018 at 08:07, Ard Biesheuvel wrote: > On 9 March 2018 at 08:04, Ingo Molnar wrote: >> >> * Ard Biesheuvel wrote: >> >>> > Also, would it make sense to rename it to something more descriptive like >>> > "apple_unicode_str[]" or so? >>> > >>> > Plus an unicode string literal initialize

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-09 Thread Ard Biesheuvel
On 9 March 2018 at 08:04, Ingo Molnar wrote: > > * Ard Biesheuvel wrote: > >> > Also, would it make sense to rename it to something more descriptive like >> > "apple_unicode_str[]" or so? >> > >> > Plus an unicode string literal initializer would be pretty descriptive as >> > well, >> > instead

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-09 Thread Ingo Molnar
* Ard Biesheuvel wrote: > > Also, would it make sense to rename it to something more descriptive like > > "apple_unicode_str[]" or so? > > > > Plus an unicode string literal initializer would be pretty descriptive as > > well, > > instead of the weird looking character array, i.e. something lik

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-08 Thread Ard Biesheuvel
On 9 March 2018 at 07:47, Ingo Molnar wrote: > > * Ard Biesheuvel wrote: > >> From: Colin Ian King >> >> Don't populate the const read-only array 'buf' on the stack but instead >> make it static. Makes the object code smaller by 64 bytes: >> >> Before: >>text data bss dec

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-08 Thread Ingo Molnar
* Ard Biesheuvel wrote: > From: Colin Ian King > > Don't populate the const read-only array 'buf' on the stack but instead > make it static. Makes the object code smaller by 64 bytes: > > Before: >text data bss dec hex filename >9264 1 169281

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-08 Thread Ard Biesheuvel
On 9 March 2018 at 07:43, Ard Biesheuvel wrote: > On 8 March 2018 at 11:05, Joe Perches wrote: >> On Thu, 2018-03-08 at 08:00 +, Ard Biesheuvel wrote: >>> From: Colin Ian King >>> >>> Don't populate the const read-only array 'buf' on the stack but instead >>> make it static. Makes the object

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-08 Thread Ard Biesheuvel
On 8 March 2018 at 11:05, Joe Perches wrote: > On Thu, 2018-03-08 at 08:00 +, Ard Biesheuvel wrote: >> From: Colin Ian King >> >> Don't populate the const read-only array 'buf' on the stack but instead >> make it static. Makes the object code smaller by 64 bytes: >> >> Before: >>text

Re: [PATCH 12/12] efi: make const array 'apple' static

2018-03-08 Thread Joe Perches
On Thu, 2018-03-08 at 08:00 +, Ard Biesheuvel wrote: > From: Colin Ian King > > Don't populate the const read-only array 'buf' on the stack but instead > make it static. Makes the object code smaller by 64 bytes: > > Before: >text data bss dec hex filename >9264