Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-07-11 Thread Brendan Higgins
On Fri, Jun 28, 2019 at 3:28 PM Luis Chamberlain wrote: > > On Fri, Jun 28, 2019 at 10:45:42AM +1000, Dave Chinner wrote: > > On Tue, Jun 25, 2019 at 12:10:20PM +0200, Christoph Hellwig wrote: > > > On Tue, Jun 25, 2019 at 09:43:04AM +1000, Dave Chinner wrote: > > > > I'm a little concerned this i

Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-07-01 Thread Dave Chinner
On Mon, Jul 01, 2019 at 08:43:33AM +0200, Christoph Hellwig wrote: > On Mon, Jul 01, 2019 at 10:08:59AM +1000, Dave Chinner wrote: > > > Why do you assume you have to test it? Back when we shared > > > generic_file_read with everyone you also didn't test odd change to > > > it with every possible

Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-06-30 Thread Christoph Hellwig
On Mon, Jul 01, 2019 at 10:08:59AM +1000, Dave Chinner wrote: > > Why do you assume you have to test it? Back when we shared > > generic_file_read with everyone you also didn't test odd change to > > it with every possible fs. > > I'm not sure what function you are referring to here. Can you > cl

Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-06-30 Thread Dave Chinner
On Fri, Jun 28, 2019 at 07:33:20AM +0200, Christoph Hellwig wrote: > On Fri, Jun 28, 2019 at 10:45:42AM +1000, Dave Chinner wrote: > > You've already mentioned two new users you want to add. I don't even > > have zone capable hardware here to test one of the users you are > > indicating will use th

Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-06-28 Thread Luis Chamberlain
On Fri, Jun 28, 2019 at 10:45:42AM +1000, Dave Chinner wrote: > On Tue, Jun 25, 2019 at 12:10:20PM +0200, Christoph Hellwig wrote: > > On Tue, Jun 25, 2019 at 09:43:04AM +1000, Dave Chinner wrote: > > > I'm a little concerned this is going to limit what we can do > > > with the XFS IO path because

Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-06-27 Thread Christoph Hellwig
On Fri, Jun 28, 2019 at 10:45:42AM +1000, Dave Chinner wrote: > You've already mentioned two new users you want to add. I don't even > have zone capable hardware here to test one of the users you are > indicating will use this code, and I suspect that very few people > do. That's a non-trivial inc

Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-06-27 Thread Dave Chinner
On Tue, Jun 25, 2019 at 12:10:20PM +0200, Christoph Hellwig wrote: > On Tue, Jun 25, 2019 at 09:43:04AM +1000, Dave Chinner wrote: > > I'm a little concerned this is going to limit what we can do > > with the XFS IO path because now we can't change this code without > > considering the direct impac

Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-06-25 Thread Christoph Hellwig
On Tue, Jun 25, 2019 at 09:43:04AM +1000, Dave Chinner wrote: > I'm a little concerned this is going to limit what we can do > with the XFS IO path because now we can't change this code without > considering the direct impact on other filesystems. The QA burden of > changing the XFS writeback code

Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-06-25 Thread Christoph Hellwig
On Mon, Jun 24, 2019 at 08:46:01AM -0700, Darrick J. Wong wrote: > This looks like a straight code copy from fs/xfs/ into fs/iomap.c. > That's fine with me, but seeing as this file is now ~2700 lines long, > perhaps we should break this up among major functional lines? > > Looking at fs/iomap.c, I

Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-06-24 Thread Dave Chinner
On Mon, Jun 24, 2019 at 07:52:52AM +0200, Christoph Hellwig wrote: > Takes the xfs writeback code and move it to iomap.c. A new structure > with three methods is added as the abstraction from the generic > writeback code to the file system. These methods are used to map > blocks, submit an ioend,

Re: [PATCH 11/12] iomap: move the xfs writeback code to iomap.c

2019-06-24 Thread Darrick J. Wong
On Mon, Jun 24, 2019 at 07:52:52AM +0200, Christoph Hellwig wrote: > Takes the xfs writeback code and move it to iomap.c. A new structure > with three methods is added as the abstraction from the generic > writeback code to the file system. These methods are used to map > blocks, submit an ioend,