On 04/23/2014 04:21 PM, Miklos Szeredi wrote:
> On Sat, Apr 19, 2014 at 11:08 AM, Michael Kerrisk (man-pages)
> wrote:
>> Hi Miklos,
>>
>>> The code changes are pushed to the git tree and the updated man page is
>>> below.
>>
>> Now that renameat2() is in 3.15, I've taken these changes. This had
On Sat, Apr 19, 2014 at 2:08 PM, Tetsuo Handa
wrote:
> Michael Kerrisk (man-pages) wrote:
>> Now that renameat2() is in 3.15, I've taken these changes.
>
> What!? I didn't know renameat2() goes to 3.15.
>
> But I assume that renameat2() is not accessible in 3.15, for I can see
> "asmlinkage long s
On Sat, Apr 19, 2014 at 11:08 AM, Michael Kerrisk (man-pages)
wrote:
> Hi Miklos,
>
>> The code changes are pushed to the git tree and the updated man page is
>> below.
>
> Now that renameat2() is in 3.15, I've taken these changes. This had to be
> manually does, because I'd done some major rewor
Michael Kerrisk (man-pages) wrote:
> Now that renameat2() is in 3.15, I've taken these changes.
What!? I didn't know renameat2() goes to 3.15.
But I assume that renameat2() is not accessible in 3.15, for I can see
"asmlinkage long sys_renameat2(" but don't see "#define __NR_renameat2".
$ grep
Hi Miklos,
> The code changes are pushed to the git tree and the updated man page is below.
Now that renameat2() is in 3.15, I've taken these changes. This had to be
manually does, because I'd done some major reworking on the pages since you
originally wrote your text. So, I may have injected s
On Mon, Jan 20, 2014 at 12:39 PM, Miklos Szeredi wrote:
> On Sat, Jan 18, 2014 at 5:27 PM, J. Bruce Fields wrote:
>> On Sat, Jan 18, 2014 at 07:49:29AM +0100, Miklos Szeredi wrote:
>>> On Fri, Jan 17, 2014 at 11:08 PM, J. Bruce Fields
>>> wrote:
>>> > On Fri, Jan 17, 2014 at 11:53:07PM +1300, M
On Sat, Jan 18, 2014 at 5:27 PM, J. Bruce Fields wrote:
> On Sat, Jan 18, 2014 at 07:49:29AM +0100, Miklos Szeredi wrote:
>> On Fri, Jan 17, 2014 at 11:08 PM, J. Bruce Fields
>> wrote:
>> > On Fri, Jan 17, 2014 at 11:53:07PM +1300, Michael Kerrisk (man-pages)
>> > wrote:
>> >> >The foll
On Sat, Jan 18, 2014 at 07:49:29AM +0100, Miklos Szeredi wrote:
> On Fri, Jan 17, 2014 at 11:08 PM, J. Bruce Fields
> wrote:
> > On Fri, Jan 17, 2014 at 11:53:07PM +1300, Michael Kerrisk (man-pages) wrote:
> >> >The following additional errors are defined for renameat2():
> >> >
> >> >
On Fri, Jan 17, 2014 at 11:08 PM, J. Bruce Fields wrote:
> On Fri, Jan 17, 2014 at 11:53:07PM +1300, Michael Kerrisk (man-pages) wrote:
>> >The following additional errors are defined for renameat2():
>> >
>> >EOPNOTSUPP
>> > The filesystem does not support a flag in
On Fri, Jan 17, 2014 at 11:53:07PM +1300, Michael Kerrisk (man-pages) wrote:
> Hi Miklos,
>
> A few comments below, including one piece in the code that really must be
> fixed.
>
> On 01/16/2014 11:54 PM, Miklos Szeredi wrote:
> >> On Wed, Jan 15, 2014 at 7:23 PM, J. Bruce Fields
> >> wrote:
>
Hi Michael,
Thanks for the review. I updated the code and man page based on your and
Bruce's comments.
The code changes are pushed to the git tree and the updated man page is below.
Thanks,
Miklos
RENAMEAT(2)Linux Programmer's Manual RENAMEAT(2)
NAME
Hi Miklos,
A few comments below, including one piece in the code that really must be fixed.
On 01/16/2014 11:54 PM, Miklos Szeredi wrote:
>> On Wed, Jan 15, 2014 at 7:23 PM, J. Bruce Fields
>> wrote:
>>> Do you have a man page update somewhere for the two new flags?
>
> Here's the updated man
On Thu, Jan 16, 2014 at 11:54:06AM +0100, Miklos Szeredi wrote:
> > On Wed, Jan 15, 2014 at 7:23 PM, J. Bruce Fields
> > wrote:
> > > Do you have a man page update somewhere for the two new flags?
>
> Here's the updated man page (and attached the patch)
Looks good to me. Total nits:
>
> On Wed, Jan 15, 2014 at 7:23 PM, J. Bruce Fields wrote:
> > Do you have a man page update somewhere for the two new flags?
Here's the updated man page (and attached the patch)
Michael, could you please review the interface?
I forgot to CC you when posing the patch series. I can resend it if
On Wed, Jan 15, 2014 at 7:23 PM, J. Bruce Fields wrote:
> On Mon, Jan 13, 2014 at 01:25:17PM +0100, Jan Kara wrote:
>> I think this deserves a comment that RENAME_EXCHANGE expects both source
>> and target to exist... I'm always pondering about this condition before I
>> realize that.
>
> Do you
On Mon, Jan 13, 2014 at 01:25:17PM +0100, Jan Kara wrote:
> I think this deserves a comment that RENAME_EXCHANGE expects both source
> and target to exist... I'm always pondering about this condition before I
> realize that.
Do you have a man page update somewhere for the two new flags?
--b.
--
On Mon, Jan 13, 2014 at 01:25:17PM +0100, Jan Kara wrote:
> On Wed 08-01-14 23:10:15, Miklos Szeredi wrote:
> > From: Miklos Szeredi
> >
> > Implement RENAME_EXCHANGE flag in renameat2 syscall.
> Yes, this is much better than last time. Thanks for the work. You can add
> Reviewed-by: Jan Kara
On Wed 08-01-14 23:10:15, Miklos Szeredi wrote:
> From: Miklos Szeredi
>
> Implement RENAME_EXCHANGE flag in renameat2 syscall.
Yes, this is much better than last time. Thanks for the work. You can add
Reviewed-by: Jan Kara
One nitpick below...
> Signed-off-by: Miklos Szeredi
> ---
> fs/e
On Tue, Nov 26, 2013 at 10:51:25AM +0100, Jan Kara wrote:
> On Wed 20-11-13 14:01:52, Miklos Szeredi wrote:
> > From: Miklos Szeredi
> >
> > Implement RENAME_EXCHANGE flag in renameat2 syscall.
> >
> > Signed-off-by: Miklos Szeredi
> > ---
> > fs/ext4/namei.c | 97
> >
On Wed 20-11-13 14:01:52, Miklos Szeredi wrote:
> From: Miklos Szeredi
>
> Implement RENAME_EXCHANGE flag in renameat2 syscall.
>
> Signed-off-by: Miklos Szeredi
> ---
> fs/ext4/namei.c | 97
> -
> 1 file changed, 69 insertions(+), 28 de
20 matches
Mail list logo
