Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver

2016-04-25 Thread Thomas Petazzoni
Hello, On Mon, 25 Apr 2016 17:46:53 +0200, Arnd Bergmann wrote: > > What code are you talking about? Initializing the OPPs or adding the > > cpufreq-dt device? The first one (or whatever is left now in that > > function) can stay anywhere, even as a cpufreq driver. I was talking > > about the fac

Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver

2016-04-25 Thread Arnd Bergmann
On Monday 25 April 2016 20:59:14 Viresh Kumar wrote: > On 25-04-16, 17:26, Arnd Bergmann wrote: > > On Monday 25 April 2016 18:26:05 Viresh Kumar wrote: > > > On 25-04-16, 14:53, Arnd Bergmann wrote: > > > > What are the downsides of moving armada_xp_pmsu_cpufreq_init() > > > > into drivers/cpufreq

Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver

2016-04-25 Thread Arnd Bergmann
On Monday 25 April 2016 18:26:05 Viresh Kumar wrote: > On 25-04-16, 14:53, Arnd Bergmann wrote: > > On Monday 25 April 2016 08:30:41 Viresh Kumar wrote: > > > I realize that the ordering is fixed through the way that the kernel > > is linked, my worry is more about someone changing the code in som

Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver

2016-04-25 Thread Viresh Kumar
On 25-04-16, 17:26, Arnd Bergmann wrote: > On Monday 25 April 2016 18:26:05 Viresh Kumar wrote: > > On 25-04-16, 14:53, Arnd Bergmann wrote: > > > On Monday 25 April 2016 08:30:41 Viresh Kumar wrote: > > > > > I realize that the ordering is fixed through the way that the kernel > > > is linked, my

Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver

2016-04-25 Thread Viresh Kumar
On 25-04-16, 14:53, Arnd Bergmann wrote: > On Monday 25 April 2016 08:30:41 Viresh Kumar wrote: > I realize that the ordering is fixed through the way that the kernel > is linked, my worry is more about someone changing the code in some > way because it's not obvious from reading the code that the

Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver

2016-04-25 Thread Arnd Bergmann
On Monday 25 April 2016 08:30:41 Viresh Kumar wrote: > On 23-04-16, 00:42, Arnd Bergmann wrote: > > On Thursday 21 April 2016 14:29:02 Viresh Kumar wrote: > > > diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c > > > index 79d0a5d9da8e..f24f46776fbb 100644 > > > --- a/arch/arm/ma

Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver

2016-04-24 Thread Viresh Kumar
On 23-04-16, 00:42, Arnd Bergmann wrote: > On Thursday 21 April 2016 14:29:02 Viresh Kumar wrote: > > diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c > > index 79d0a5d9da8e..f24f46776fbb 100644 > > --- a/arch/arm/mach-mvebu/pmsu.c > > +++ b/arch/arm/mach-mvebu/pmsu.c > > @@ -68

Re: [PATCH 10/10] cpufreq: mvebu: Use generic platdev driver

2016-04-22 Thread Arnd Bergmann
On Thursday 21 April 2016 14:29:02 Viresh Kumar wrote: > diff --git a/arch/arm/mach-mvebu/pmsu.c b/arch/arm/mach-mvebu/pmsu.c > index 79d0a5d9da8e..f24f46776fbb 100644 > --- a/arch/arm/mach-mvebu/pmsu.c > +++ b/arch/arm/mach-mvebu/pmsu.c > @@ -685,8 +685,6 @@ static int __init armada_xp_pmsu_cpufre