Re: [PATCH 1/8] ixgbe: Out of line ixgbe_read/write_reg

2014-05-20 Thread Rustad, Mark D
On May 19, 2014, at 4:25 PM, Andi Kleen wrote: > On Mon, May 19, 2014 at 10:00:52PM +, Rustad, Mark D wrote: >> On May 16, 2014, at 2:43 PM, Andi Kleen wrote: >> >>> From: Andi Kleen >>> >>> ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big >>> because they have co

Re: [PATCH 1/8] ixgbe: Out of line ixgbe_read/write_reg

2014-05-19 Thread Andi Kleen
On Mon, May 19, 2014 at 10:00:52PM +, Rustad, Mark D wrote: > On May 16, 2014, at 2:43 PM, Andi Kleen wrote: > > > From: Andi Kleen > > > > ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big > > because they have complex error handling code. > > Actually, this patch

Re: [PATCH 1/8] ixgbe: Out of line ixgbe_read/write_reg

2014-05-19 Thread Rustad, Mark D
On May 16, 2014, at 2:43 PM, Andi Kleen wrote: > From: Andi Kleen > > ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big > because they have complex error handling code. Actually, this patch doesn't do anything to ixgbe_write_reg, which would almost certainly be very ba

RE: [PATCH 1/8] ixgbe: Out of line ixgbe_read/write_reg

2014-05-19 Thread David Laight
From: Andi Kleen > ixgbe_read_reg and ixgbe_write_reg are frequently called and are very big > because they have complex error handling code. Have you measured the performance impact? I suspect that it might me measurable. Clearly the calls during initialisation don't need to be inline, but there