Re: [PATCH 1/7] Add a new flags-accepting interface for anonymous inodes

2019-10-15 Thread Christoph Hellwig
On Sat, Oct 12, 2019 at 12:15:56PM -0700, Daniel Colascione wrote: > Add functions forwarding from the old names to the new ones so we > don't need to change any callers. Independent of the usefulness of the interface (I'll let other comment, but you defintively want to talk to Al Viro), adding a

Re: [PATCH 1/7] Add a new flags-accepting interface for anonymous inodes

2019-10-14 Thread Jann Horn
On Mon, Oct 14, 2019 at 8:16 PM Daniel Colascione wrote: > On Mon, Oct 14, 2019 at 8:39 AM Jann Horn wrote: > > > > On Sat, Oct 12, 2019 at 9:16 PM Daniel Colascione wrote: > > > Add functions forwarding from the old names to the new ones so we > > > don't need to change any callers. > > > > Thi

Re: [PATCH 1/7] Add a new flags-accepting interface for anonymous inodes

2019-10-14 Thread Daniel Colascione
Thanks for taking a look On Mon, Oct 14, 2019 at 8:39 AM Jann Horn wrote: > > On Sat, Oct 12, 2019 at 9:16 PM Daniel Colascione wrote: > > Add functions forwarding from the old names to the new ones so we > > don't need to change any callers. > > This patch does more than the commit message says

Re: [PATCH 1/7] Add a new flags-accepting interface for anonymous inodes

2019-10-14 Thread Jann Horn
On Sat, Oct 12, 2019 at 9:16 PM Daniel Colascione wrote: > Add functions forwarding from the old names to the new ones so we > don't need to change any callers. This patch does more than the commit message says; it also refactors the body of the function. (I would've moved that refactoring over i

Re: [PATCH 1/7] Add a new flags-accepting interface for anonymous inodes

2019-10-13 Thread kbuild test robot
Hi Daniel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.4-rc3 next-20191011] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to sp