Re: [PATCH 1/6] serial: 8250_dw: add support for clk api

2013-03-15 Thread Emilio López
El 15/03/13 21:29, Russell King - ARM Linux escribió: > On Fri, Mar 15, 2013 at 09:15:11PM -0300, Emilio López wrote: >> Hello Russell, >> >> El 15/03/13 19:39, Russell King - ARM Linux escribió: >>> On Fri, Mar 15, 2013 at 09:06:23PM +0100, Maxime Ripard wrote: + /* clock got configured thro

Re: [PATCH 1/6] serial: 8250_dw: add support for clk api

2013-03-15 Thread Russell King - ARM Linux
On Fri, Mar 15, 2013 at 09:15:11PM -0300, Emilio López wrote: > Hello Russell, > > El 15/03/13 19:39, Russell King - ARM Linux escribió: > > On Fri, Mar 15, 2013 at 09:06:23PM +0100, Maxime Ripard wrote: > >> + /* clock got configured through clk api, all done */ > >> + if (p->uartclk) > > > >

Re: [PATCH 1/6] serial: 8250_dw: add support for clk api

2013-03-15 Thread Emilio López
Hello Russell, El 15/03/13 19:39, Russell King - ARM Linux escribió: > On Fri, Mar 15, 2013 at 09:06:23PM +0100, Maxime Ripard wrote: >> +/* clock got configured through clk api, all done */ >> +if (p->uartclk) > > if (IS_ERR(p->uartclk)) > Isn't IS_ERR for pointers? p->uartclk is

Re: [PATCH 1/6] serial: 8250_dw: add support for clk api

2013-03-15 Thread Russell King - ARM Linux
On Fri, Mar 15, 2013 at 09:06:23PM +0100, Maxime Ripard wrote: > + /* clock got configured through clk api, all done */ > + if (p->uartclk) if (IS_ERR(p->uartclk)) > + return 0; > + > + /* try to find out clock frequency from DT as fallback */ > if (of_proper