Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Marc Zyngier
On 08/02/16 14:48, Antoine Tenart wrote: > On Mon, Feb 08, 2016 at 02:29:12PM +, Marc Zyngier wrote: >> On 08/02/16 14:17, Antoine Tenart wrote: >>> Thomas, >>> >>> On Mon, Feb 08, 2016 at 11:31:47AM +0100, Thomas Gleixner wrote: On Mon, 8 Feb 2016, Antoine Tenart wrote: > +static int

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Antoine Tenart
On Mon, Feb 08, 2016 at 02:29:12PM +, Marc Zyngier wrote: > On 08/02/16 14:17, Antoine Tenart wrote: > > Thomas, > > > > On Mon, Feb 08, 2016 at 11:31:47AM +0100, Thomas Gleixner wrote: > >> On Mon, 8 Feb 2016, Antoine Tenart wrote: > >>> +static int alpine_msix_set_affinity(struct irq_data *i

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Marc Zyngier
On 08/02/16 14:17, Antoine Tenart wrote: > Thomas, > > On Mon, Feb 08, 2016 at 11:31:47AM +0100, Thomas Gleixner wrote: >> On Mon, 8 Feb 2016, Antoine Tenart wrote: >>> +static int alpine_msix_set_affinity(struct irq_data *irq_data, >>> + const struct cpumask *mask, b

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Antoine Tenart
Thomas, On Mon, Feb 08, 2016 at 11:31:47AM +0100, Thomas Gleixner wrote: > On Mon, 8 Feb 2016, Antoine Tenart wrote: > > +static int alpine_msix_set_affinity(struct irq_data *irq_data, > > + const struct cpumask *mask, bool force) > > +{ > > + int ret; > > + > > +

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Marc Zyngier
On 08/02/16 14:04, Antoine Tenart wrote: > Hi Marc, > > On Mon, Feb 08, 2016 at 09:44:49AM +, Marc Zyngier wrote: >> On 08/02/16 09:16, Antoine Tenart wrote: >>> + >>> +static struct msi_domain_info alpine_msix_domain_info = { >>> + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Antoine Tenart
Hi Marc, On Mon, Feb 08, 2016 at 09:44:49AM +, Marc Zyngier wrote: > On 08/02/16 09:16, Antoine Tenart wrote: > > + > > +static struct msi_domain_info alpine_msix_domain_info = { > > + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > > + MSI_FLAG_PCI_MSIX, > >

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Antoine Tenart
On Mon, Feb 08, 2016 at 10:56:16AM +, Marc Zyngier wrote: > On 08/02/16 10:44, Antoine Tenart wrote: > > On Mon, Feb 08, 2016 at 10:32:08AM +, Marc Zyngier wrote: > >> On 08/02/16 10:26, Antoine Tenart wrote: > > +static int alpine_msix_init(struct device_node *node, > > +

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Marc Zyngier
On 08/02/16 10:44, Antoine Tenart wrote: > On Mon, Feb 08, 2016 at 10:32:08AM +, Marc Zyngier wrote: >> On 08/02/16 10:26, Antoine Tenart wrote: > +static int alpine_msix_init(struct device_node *node, > + struct device_node *parent) > +{ > + struct alpine_ms

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Antoine Tenart
On Mon, Feb 08, 2016 at 10:32:08AM +, Marc Zyngier wrote: > On 08/02/16 10:26, Antoine Tenart wrote: > >>> +static int alpine_msix_init(struct device_node *node, > >>> + struct device_node *parent) > >>> +{ > >>> + struct alpine_msix_data *priv; > >>> + struct resource res;

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Thomas Gleixner
Antoine, On Mon, 8 Feb 2016, Antoine Tenart wrote: > +static int alpine_msix_set_affinity(struct irq_data *irq_data, > + const struct cpumask *mask, bool force) > +{ > + int ret; > + > + ret = irq_chip_set_affinity_parent(irq_data, mask, force); > + retu

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Marc Zyngier
On 08/02/16 10:26, Antoine Tenart wrote: >>> +static int alpine_msix_init(struct device_node *node, >>> + struct device_node *parent) >>> +{ >>> + struct alpine_msix_data *priv; >>> + struct resource res; >>> + int ret; >>> + >>> + priv = kzalloc(sizeof(*priv), GFP_KER

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Antoine Tenart
Hi Marc, On Mon, Feb 08, 2016 at 09:44:49AM +, Marc Zyngier wrote: > On 08/02/16 09:16, Antoine Tenart wrote: > > + > > +/* MSIX message address format: local GIC target */ > > +#define ALPINE_MSIX_SPI_TARGET_CLUSTER0BIT(16) > > + > > +struct alpine_msix_data { > > + spinlock_t m

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Marc Zyngier
Hi Thomas, On 08/02/16 09:53, Thomas Petazzoni wrote: > Hello Marc, > > On Mon, 8 Feb 2016 09:44:49 +, Marc Zyngier wrote: > >>> +static struct msi_domain_info alpine_msix_domain_info = { >>> + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | >>> + MSI_FLAG_PCI_

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Thomas Petazzoni
Hello Marc, On Mon, 8 Feb 2016 09:44:49 +, Marc Zyngier wrote: > > +static struct msi_domain_info alpine_msix_domain_info = { > > + .flags = MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS | > > + MSI_FLAG_PCI_MSIX, > > You can probably add MSI_FLAG_PCI_MSI, it should wor

Re: [PATCH 1/6] irqchip: add the Alpine MSIX interrupt controller

2016-02-08 Thread Marc Zyngier
Hi Antoine, On 08/02/16 09:16, Antoine Tenart wrote: > This patch adds the Alpine MSIX interrupt controller driver. > > Signed-off-by: Antoine Tenart > Signed-off-by: Tsahee Zidenberg > --- > drivers/irqchip/Kconfig | 6 + > drivers/irqchip/Makefile | 1 + > drivers/irqchi