Re: [PATCH 1/6] driver-core : add class iteration api

2008-01-22 Thread Dave Young
On Jan 23, 2008 6:25 AM, Greg KH <[EMAIL PROTECTED]> wrote: > On Tue, Jan 22, 2008 at 03:27:08PM +0800, Dave Young wrote: > > > > Add the following class iteration functions for driver use: > > class_for_each_device > > class_find_device > > class_for_each_child > > class_find_child > > As class_fo

Re: [PATCH 1/6] driver-core : add class iteration api

2008-01-22 Thread Greg KH
On Tue, Jan 22, 2008 at 03:27:08PM +0800, Dave Young wrote: > > Add the following class iteration functions for driver use: > class_for_each_device > class_find_device > class_for_each_child > class_find_child As class_for_each_child() is not used by anyone in this patch series, and we want to he

Re: [PATCH 1/6] driver-core : add class iteration api

2008-01-22 Thread Cornelia Huck
On Tue, 22 Jan 2008 15:27:08 +0800, Dave Young <[EMAIL PROTECTED]> wrote: > On Mon, Jan 21, 2008 at 10:24:17PM -0800, David Brownell wrote: > > This is called with class->sem held. So fn() has a > > constraint to not re-acquire that ... else it'd be > > self-deadlocking. I'd like to see docs at

Re: [PATCH 1/6] driver-core : add class iteration api

2008-01-21 Thread Dave Young
On Mon, Jan 21, 2008 at 10:24:17PM -0800, David Brownell wrote: > On Monday 21 January 2008, Dave Young wrote: > > > > +/** > > + * class_for_each_device - device iterator > > + * @class: the class we're iterating > > + * @data: data for the callback > > + * @fn: function to be called for each de

Re: [PATCH 1/6] driver-core : add class iteration api

2008-01-21 Thread Dave Young
On Jan 22, 2008 2:24 PM, David Brownell <[EMAIL PROTECTED]> wrote: > On Monday 21 January 2008, Dave Young wrote: > > > > +/** > > + * class_for_each_device - device iterator > > + * @class: the class we're iterating > > + * @data: data for the callback > > + * @fn: function to be called fo

Re: [PATCH 1/6] driver-core : add class iteration api

2008-01-21 Thread David Brownell
On Monday 21 January 2008, Dave Young wrote: > > +/** > + * class_for_each_device - device iterator > + * @class: the class we're iterating > + * @data: data for the callback > + * @fn: function to be called for each device > + * > + * Iterate over @class's list of devices, and call @fn

Re: [PATCH 1/6] driver-core : add class iteration api

2008-01-21 Thread Dave Young
On Jan 22, 2008 1:54 PM, Dave Young <[EMAIL PROTECTED]> wrote: > > Add the following class iteration functions for driver use: > class_for_each_device > class_find_device > class_for_each_child > class_find_child > > Signed-off-by: Dave Young <[EMAIL PROTECTED]> > Acked-by: Cornelia Huck <[EMAIL P