Re: [PATCH 1/5] locking/qspinlock: Safely handle > 4 nesting levels

2019-01-21 Thread Will Deacon
On Mon, Jan 21, 2019 at 10:12:34AM +0100, Peter Zijlstra wrote: > diff --git a/kernel/locking/qspinlock.c b/kernel/locking/qspinlock.c > index 8a8c3c208c5e..983b49a75826 100644 > --- a/kernel/locking/qspinlock.c > +++ b/kernel/locking/qspinlock.c > @@ -412,6 +412,12 @@ void queued_spin_lock_slowpat

Re: [PATCH 1/5] locking/qspinlock: Safely handle > 4 nesting levels

2019-01-21 Thread Waiman Long
On 01/21/2019 04:12 AM, Peter Zijlstra wrote: > On Sun, Jan 20, 2019 at 09:49:50PM -0500, Waiman Long wrote: >> +/** >> + * acquire_lock_no_node - acquire lock without MCS node >> + * @lock: Pointer to queued spinlock structure >> + * >> + * It is extremely unlikely that this function will ever

Re: [PATCH 1/5] locking/qspinlock: Safely handle > 4 nesting levels

2019-01-21 Thread Peter Zijlstra
On Sun, Jan 20, 2019 at 09:49:50PM -0500, Waiman Long wrote: > +/** > + * acquire_lock_no_node - acquire lock without MCS node > + * @lock: Pointer to queued spinlock structure > + * > + * It is extremely unlikely that this function will ever be called. > + * Marking it as noinline to not mess