Re: [PATCH 1/5] clk: qcom: Add EBI2 clocks for IPQ806x

2015-01-29 Thread Stephen Boyd
On 01/16/15 06:48, Archit Taneja wrote: > + > +static struct clk_branch ebi2_aon_clk = { > + .hwcg_reg = 0x3b00, > + .hwcg_bit = 6, It looks like these bits only apply to ebi2_clk, and not ebi2_aon_clk, so these two lines should be dropped. > + .halt_reg = 0x2fcc, > + .halt_bit =

Re: [PATCH 1/5] clk: qcom: Add EBI2 clocks for IPQ806x

2015-01-19 Thread Archit Taneja
Hi, On 01/17/2015 03:26 AM, Stephen Boyd wrote: On 01/16/2015 06:48 AM, Archit Taneja wrote: The NAND controller within EBI2 requires EBI2_CLK and EBI2_ALWAYS_ON_CLK clocks. Create structs for these clocks so that they can be used by the NAND controller driver. Add an entry for EBI2_AON_CLK in

Re: [PATCH 1/5] clk: qcom: Add EBI2 clocks for IPQ806x

2015-01-16 Thread Stephen Boyd
On 01/16/2015 06:48 AM, Archit Taneja wrote: > The NAND controller within EBI2 requires EBI2_CLK and EBI2_ALWAYS_ON_CLK > clocks. > Create structs for these clocks so that they can be used by the NAND > controller > driver. Add an entry for EBI2_AON_CLK in the gcc-ipq806x DT binding document. > >