Re: [PATCH 1/5] backlight: Add GPIO-based backlight driver

2012-11-27 Thread Laurent Pinchart
Hi Jingoo, On Tuesday 27 November 2012 01:10:36 Jingoo Han wrote: > On Saturday, November 24, 2012 1:35 AM, Laurent Pinchart wrote > > > > > Signed-off-by: Laurent Pinchart > > --- > > > > drivers/video/backlight/Kconfig |7 ++ > > drivers/video/backlight/Makefile |1

Re: [PATCH 1/5] backlight: Add GPIO-based backlight driver

2012-11-26 Thread Jingoo Han
On Monday, November 26, 2012 7:25 PM, Laurent Pinchart wrote > > Hi Jingoo, > > On Monday 26 November 2012 09:49:36 Jingoo Han wrote: > > On Saturday, November 24, 2012 1:35 AM, Laurent Pinchart wrote > > > > > > Signed-off-by: Laurent Pinchart > > > > CC'ed Andrew Morton > > > > It looks good.

Re: [PATCH 1/5] backlight: Add GPIO-based backlight driver

2012-11-26 Thread Jingoo Han
On Saturday, November 24, 2012 1:35 AM, Laurent Pinchart wrote > > Signed-off-by: Laurent Pinchart > --- > drivers/video/backlight/Kconfig |7 ++ > drivers/video/backlight/Makefile |1 + > drivers/video/backlight/gpio_backlight.c | 158 > ++

Re: [PATCH 1/5] backlight: Add GPIO-based backlight driver

2012-11-26 Thread Laurent Pinchart
Hi Lars-Peter, On Monday 26 November 2012 11:44:04 Lars-Peter Clausen wrote: > On 11/26/2012 10:49 AM, Jingoo Han wrote: > > On Saturday, November 24, 2012 1:35 AM, Laurent Pinchart wrote > > [...] > > >> +static int gpio_backlight_check_fb(struct backlight_device *bl, > >> +

Re: [PATCH 1/5] backlight: Add GPIO-based backlight driver

2012-11-26 Thread Lars-Peter Clausen
On 11/26/2012 10:49 AM, Jingoo Han wrote: > On Saturday, November 24, 2012 1:35 AM, Laurent Pinchart wrote [...] >> +static int gpio_backlight_check_fb(struct backlight_device *bl, >> + struct fb_info *info) >> +{ >> +struct gpio_backlight *gbl = bl_get_data(bl); >

Re: [PATCH 1/5] backlight: Add GPIO-based backlight driver

2012-11-26 Thread Laurent Pinchart
Hi Jingoo, On Monday 26 November 2012 09:49:36 Jingoo Han wrote: > On Saturday, November 24, 2012 1:35 AM, Laurent Pinchart wrote > > > > Signed-off-by: Laurent Pinchart > > CC'ed Andrew Morton > > It looks good. Also, I tested this patch with SMDK4210 board. > Acked-by: Jingoo Han Thank you

Re: [PATCH 1/5] backlight: Add GPIO-based backlight driver

2012-11-26 Thread Jingoo Han
On Saturday, November 24, 2012 1:35 AM, Laurent Pinchart wrote > > Signed-off-by: Laurent Pinchart CC'ed Andrew Morton It looks good. Also, I tested this patch with SMDK4210 board. Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/backlight/Kconfig |7 ++ > dr