Re: [PATCH 1/5] USB: ehci-atmel: rework clk handling

2015-03-18 Thread Douglas Gilbert
On 15-03-18 08:28 AM, Greg Kroah-Hartman wrote: On Wed, Mar 18, 2015 at 12:16:22PM +0100, Nicolas Ferre wrote: Le 17/03/2015 20:01, Alan Stern a écrit : On Tue, 17 Mar 2015, Boris Brezillon wrote: The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (iclk) clocks to work properly. R

Re: [PATCH 1/5] USB: ehci-atmel: rework clk handling

2015-03-18 Thread Greg Kroah-Hartman
On Wed, Mar 18, 2015 at 12:16:22PM +0100, Nicolas Ferre wrote: > Le 17/03/2015 20:01, Alan Stern a écrit : > > On Tue, 17 Mar 2015, Boris Brezillon wrote: > > > >> The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (iclk) > >> clocks to work properly. Remove the useless system clock (f

Re: [PATCH 1/5] USB: ehci-atmel: rework clk handling

2015-03-18 Thread Nicolas Ferre
Le 17/03/2015 20:01, Alan Stern a écrit : > On Tue, 17 Mar 2015, Boris Brezillon wrote: > >> The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (iclk) >> clocks to work properly. Remove the useless system clock (fclk). >> >> Avoid calling set_rate on the fixed rate UTMI/IPLL clock and

Re: [PATCH 1/5] USB: ehci-atmel: rework clk handling

2015-03-17 Thread Alan Stern
On Tue, 17 Mar 2015, Boris Brezillon wrote: > The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (iclk) > clocks to work properly. Remove the useless system clock (fclk). > > Avoid calling set_rate on the fixed rate UTMI/IPLL clock and remove > useless IS_ENABLED(CONFIG_COMMON_CLK) te