Re: [PATCH 1/4] tracing: Simplify assignment parsing for hist triggers

2019-06-28 Thread Tom Zanussi
Hi Masami, On Fri, 2019-06-28 at 14:39 +0900, Masami Hiramatsu wrote: > On Thu, 27 Jun 2019 10:35:16 -0500 > Tom Zanussi wrote: > > > In the process of adding better error messages for sorting, I > > realized > > that strsep was being used incorrectly and some of the error paths > > I > > was ex

Re: [PATCH 1/4] tracing: Simplify assignment parsing for hist triggers

2019-06-27 Thread Masami Hiramatsu
On Thu, 27 Jun 2019 10:35:16 -0500 Tom Zanussi wrote: > In the process of adding better error messages for sorting, I realized > that strsep was being used incorrectly and some of the error paths I > was expecting to be hit weren't and just fell through to the common > invalid key error case. Wo