Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-12-25 Thread Pavel Machek
Hi! > > Could we somehow remedy the lack of knowledge from the core as whether > > the HW sends/receives characters first before adding support for LED > > triggers? It would be more generic and future proof to require UART > > drivers to report to the core when they actually TX/RX, and then at th

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-12-25 Thread Pavel Machek
Hi! > As the serial core layer does not know when the hardware actually sends > or receives characters, this needs help from the UART drivers. The > LED triggers are registered in uart_add_led_triggers() called from > the UART drivers which want to support LED triggers. All the driver > has to do

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-12-06 Thread One Thousand Gnomes
> > If we have different UART drivers, only one of them provides ttyS*, no? > > Other drivers will have to use another namespace. > > I remember this was a problem a couple of years ago last I tried, with > the 8250 driver being actually preventing other drivers from using > ttyS*, but if you do

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-27 Thread Florian Fainelli
On 11/24/2016 12:17 AM, Sascha Hauer wrote: > On Wed, Nov 23, 2016 at 10:57:13AM -0800, Florian Fainelli wrote: >> On 11/23/2016 02:01 AM, Sascha Hauer wrote: >>> With this patch the serial core provides LED triggers for RX and TX. >>> >>> As the serial core layer does not know when the hardware

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-25 Thread Sascha Hauer
On Thu, Nov 24, 2016 at 08:45:43AM -0700, Mathieu Poirier wrote: > On Thu, Nov 24, 2016 at 07:41:37AM +0100, Sascha Hauer wrote: > > On Wed, Nov 23, 2016 at 10:13:02AM -0700, Mathieu Poirier wrote: > > > On Wed, Nov 23, 2016 at 11:01:03AM +0100, Sascha Hauer wrote: > > > > With this patch the seria

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-24 Thread Mathieu Poirier
On Thu, Nov 24, 2016 at 07:41:37AM +0100, Sascha Hauer wrote: > On Wed, Nov 23, 2016 at 10:13:02AM -0700, Mathieu Poirier wrote: > > On Wed, Nov 23, 2016 at 11:01:03AM +0100, Sascha Hauer wrote: > > > With this patch the serial core provides LED triggers for RX and TX. > > > > > > As the serial co

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-24 Thread Greg Kroah-Hartman
On Thu, Nov 24, 2016 at 09:26:26AM +0100, Sascha Hauer wrote: > On Wed, Nov 23, 2016 at 11:08:19AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Nov 23, 2016 at 11:01:03AM +0100, Sascha Hauer wrote: > > > With this patch the serial core provides LED triggers for RX and TX. > > > > > > As the serial

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-24 Thread Sascha Hauer
On Wed, Nov 23, 2016 at 11:08:19AM +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 23, 2016 at 11:01:03AM +0100, Sascha Hauer wrote: > > With this patch the serial core provides LED triggers for RX and TX. > > > > As the serial core layer does not know when the hardware actually sends > > or receiv

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-24 Thread Sascha Hauer
On Wed, Nov 23, 2016 at 10:57:13AM -0800, Florian Fainelli wrote: > On 11/23/2016 02:01 AM, Sascha Hauer wrote: > > With this patch the serial core provides LED triggers for RX and TX. > > > > As the serial core layer does not know when the hardware actually sends > > or receives characters, this

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-23 Thread Sascha Hauer
On Wed, Nov 23, 2016 at 10:13:02AM -0700, Mathieu Poirier wrote: > On Wed, Nov 23, 2016 at 11:01:03AM +0100, Sascha Hauer wrote: > > With this patch the serial core provides LED triggers for RX and TX. > > > > As the serial core layer does not know when the hardware actually sends > > or receives

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-23 Thread kbuild test robot
Hi Sascha, [auto build test WARNING on tty/tty-testing] [also build test WARNING on v4.9-rc6 next-20161123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sascha-Hauer/serial-core-Add-LED-trigge

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-23 Thread Florian Fainelli
On 11/23/2016 02:01 AM, Sascha Hauer wrote: > With this patch the serial core provides LED triggers for RX and TX. > > As the serial core layer does not know when the hardware actually sends > or receives characters, this needs help from the UART drivers. Looking at 8250, we call serial8250_tx_ch

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-23 Thread Mathieu Poirier
On Wed, Nov 23, 2016 at 11:01:03AM +0100, Sascha Hauer wrote: > With this patch the serial core provides LED triggers for RX and TX. > > As the serial core layer does not know when the hardware actually sends > or receives characters, this needs help from the UART drivers. The > LED triggers are r

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-23 Thread Sascha Hauer
On Wed, Nov 23, 2016 at 11:08:19AM +0100, Greg Kroah-Hartman wrote: > On Wed, Nov 23, 2016 at 11:01:03AM +0100, Sascha Hauer wrote: > > With this patch the serial core provides LED triggers for RX and TX. > > > > As the serial core layer does not know when the hardware actually sends > > or receiv

Re: [PATCH 1/4] serial: core: Add LED trigger support

2016-11-23 Thread Greg Kroah-Hartman
On Wed, Nov 23, 2016 at 11:01:03AM +0100, Sascha Hauer wrote: > With this patch the serial core provides LED triggers for RX and TX. > > As the serial core layer does not know when the hardware actually sends > or receives characters, this needs help from the UART drivers. The > LED triggers are r