Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2015-01-30 Thread Ray Jui
On 1/30/2015 6:18 AM, Linus Walleij wrote: > On Fri, Jan 23, 2015 at 7:49 AM, Ray Jui wrote: > >> I dig into the pinctrl framework code a bit more and found that I can >> use pinctrl_request_gpio from the GPIO driver and implement >> gpio_request_enable in the pinctrl driver. > > Yep :) ain't

Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2015-01-30 Thread Linus Walleij
On Fri, Jan 23, 2015 at 7:49 AM, Ray Jui wrote: > I dig into the pinctrl framework code a bit more and found that I can > use pinctrl_request_gpio from the GPIO driver and implement > gpio_request_enable in the pinctrl driver. Yep :) ain't it nice. > The only problem I see now is that these API

Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2015-01-30 Thread Linus Walleij
On Fri, Jan 23, 2015 at 3:14 AM, Ray Jui wrote: > I have another question here. In the B0 revision of our Cygnus chip, the > ASIC team added a feature to allow individual pins to be muxed to GPIO. > The pinmux controller can still only do group-based muxing in general, > but at the same time, you

Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2015-01-22 Thread Ray Jui
On 1/22/2015 6:14 PM, Ray Jui wrote: > > > On 1/13/2015 12:20 AM, Linus Walleij wrote: >> On Fri, Jan 9, 2015 at 7:26 PM, Ray Jui wrote: >>> On 1/9/2015 2:12 AM, Linus Walleij wrote: >> Just use "groups" and "function" and refer to Documentation/devicetree/bindings/pinctrl/pinctrl-bi

Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2015-01-22 Thread Ray Jui
On 1/13/2015 12:20 AM, Linus Walleij wrote: > On Fri, Jan 9, 2015 at 7:26 PM, Ray Jui wrote: >> On 1/9/2015 2:12 AM, Linus Walleij wrote: > >>> Just use "groups" and "function" and refer to >>> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt >>> >>> Then "alt1", "alt2" etc are no

Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2015-01-13 Thread Ray Jui
On 1/13/2015 12:20 AM, Linus Walleij wrote: > On Fri, Jan 9, 2015 at 7:26 PM, Ray Jui wrote: >> On 1/9/2015 2:12 AM, Linus Walleij wrote: > >>> Just use "groups" and "function" and refer to >>> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt >>> >>> Then "alt1", "alt2" etc are no

Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2015-01-13 Thread Linus Walleij
On Fri, Jan 9, 2015 at 7:26 PM, Ray Jui wrote: > On 1/9/2015 2:12 AM, Linus Walleij wrote: >> Just use "groups" and "function" and refer to >> Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt >> >> Then "alt1", "alt2" etc are non-functional names of functions. >> Use the real functi

Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2015-01-09 Thread Ray Jui
On 1/9/2015 2:12 AM, Linus Walleij wrote: > On Fri, Nov 28, 2014 at 12:46 AM, Ray Jui wrote: > >> Device tree binding documentation for Broadcom Cygnus pinctrl driver >> >> Signed-off-by: Ray Jui >> Reviewed-by: Scott Branden >> --- >> .../bindings/pinctrl/brcm,cygnus-pinctrl.txt | 9

Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2015-01-09 Thread Linus Walleij
On Fri, Nov 28, 2014 at 12:46 AM, Ray Jui wrote: > Device tree binding documentation for Broadcom Cygnus pinctrl driver > > Signed-off-by: Ray Jui > Reviewed-by: Scott Branden > --- > .../bindings/pinctrl/brcm,cygnus-pinctrl.txt | 92 > > 1 file changed, 92 insert

Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2014-12-04 Thread Ray Jui
On 12/4/2014 2:16 PM, Belisko Marek wrote: On Thu, Dec 4, 2014 at 10:56 PM, Ray Jui wrote: Device tree binding documentation for Broadcom Cygnus pinctrl driver Signed-off-by: Ray Jui Reviewed-by: Scott Branden --- .../bindings/pinctrl/brcm,cygnus-pinctrl.txt | 92

Re: [PATCH 1/4] pinctrl: Broadcom Cygnus pinctrl device tree binding

2014-12-04 Thread Belisko Marek
On Thu, Dec 4, 2014 at 10:56 PM, Ray Jui wrote: > Device tree binding documentation for Broadcom Cygnus pinctrl driver > > Signed-off-by: Ray Jui > Reviewed-by: Scott Branden > --- > .../bindings/pinctrl/brcm,cygnus-pinctrl.txt | 92 > > 1 file changed, 92 insertio