Re: [PATCH 1/4] perf ui progress: Make sure we always define step value

2017-09-09 Thread Milian Wolff
On Freitag, 8. September 2017 15:26:42 CEST Arnaldo Carvalho de Melo wrote: > Em Fri, Sep 08, 2017 at 03:16:37PM +0200, Milian Wolff escreveu: > > On Freitag, 8. September 2017 14:05:07 CEST Jiri Olsa wrote: > > > +++ b/tools/perf/ui/progress.c > > > @@ -25,7 +25,7 @@ void ui_progress__update(struc

Re: [PATCH 1/4] perf ui progress: Make sure we always define step value

2017-09-08 Thread Arnaldo Carvalho de Melo
Em Fri, Sep 08, 2017 at 03:16:37PM +0200, Milian Wolff escreveu: > On Freitag, 8. September 2017 14:05:07 CEST Jiri Olsa wrote: > > +++ b/tools/perf/ui/progress.c > > @@ -25,7 +25,7 @@ void ui_progress__update(struct ui_progress *p, u64 adv) > > void ui_progress__init(struct ui_progress *p, u64 to

Re: [PATCH 1/4] perf ui progress: Make sure we always define step value

2017-09-08 Thread Milian Wolff
On Freitag, 8. September 2017 14:05:07 CEST Jiri Olsa wrote: > Unlikely, but we could have ui_progress__init being called > with total < 16, which would set the next and step variables > to 0. That would force unnecessary ui_progress__ops->update > calls because 'next' would never raise. > > Forci