Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

2016-06-06 Thread Andi Kleen
On Mon, Jun 06, 2016 at 11:11:40AM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Jun 06, 2016 at 11:00:03AM -0300, Arnaldo Carvalho de Melo escreveu: > > The kernel patches are in tip/perf/core now, so I applied the patches > > and they seem to work, but they broke one 'perf test' entry: > > >

Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

2016-06-06 Thread Arnaldo Carvalho de Melo
Em Mon, Jun 06, 2016 at 11:00:03AM -0300, Arnaldo Carvalho de Melo escreveu: > The kernel patches are in tip/perf/core now, so I applied the patches > and they seem to work, but they broke one 'perf test' entry: > # perf test -v 5 > > running test 50 '4:0x6530160/name=numpmu/' > running test 51

Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

2016-06-06 Thread Arnaldo Carvalho de Melo
Em Mon, May 30, 2016 at 01:19:42PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, May 30, 2016 at 09:04:02AM -0700, Andi Kleen escreveu: > > > Which is a Broadwell-U, dual-core, 14 nm. > > > > > > [root@jouet linux]# echo 0 > /proc/sys/kernel/nmi_watchdog > > > [root@jouet linux]# perf stat -

Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

2016-06-02 Thread Nilay Vaish
This patch looks fine to me. -- Nilay On 1 June 2016 at 10:24, Andi Kleen wrote: > > Here's an updated patch addresses the duplicated issue and explicitly frees > memory. > > --- > > Add basic plumbing for TopDown in perf stat > > TopDown is intended to replace the frontend cycles idle/ > backe

Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

2016-06-01 Thread Andi Kleen
Here's an updated patch addresses the duplicated issue and explicitly frees memory. --- Add basic plumbing for TopDown in perf stat TopDown is intended to replace the frontend cycles idle/ backend cycles idle metrics in standard perf stat output. These metrics are not reliable in many workload

Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

2016-06-01 Thread Andi Kleen
On Wed, Jun 01, 2016 at 09:24:33AM -0500, Nilay Vaish wrote: > On 24 May 2016 at 14:52, Andi Kleen wrote: > > From: Andi Kleen > > > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > > index 715a1128daeb..dab184d86816 100644 > > --- a/tools/perf/builtin-stat.c > > +++ b/tools

Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

2016-06-01 Thread Nilay Vaish
On 24 May 2016 at 14:52, Andi Kleen wrote: > From: Andi Kleen > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index 715a1128daeb..dab184d86816 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -59,10 +59,13 @@ > #include "util/thread.h" > #

Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

2016-05-30 Thread Arnaldo Carvalho de Melo
Em Mon, May 30, 2016 at 09:04:02AM -0700, Andi Kleen escreveu: > > Which is a Broadwell-U, dual-core, 14 nm. > > > > [root@jouet linux]# echo 0 > /proc/sys/kernel/nmi_watchdog > > [root@jouet linux]# perf stat --topdown -a usleep 1 > > System does not support topdown > > [root@jouet linux]# cat /p

Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

2016-05-30 Thread Andi Kleen
> Which is a Broadwell-U, dual-core, 14 nm. > > [root@jouet linux]# echo 0 > /proc/sys/kernel/nmi_watchdog > [root@jouet linux]# perf stat --topdown -a usleep 1 > System does not support topdown > [root@jouet linux]# cat /proc/sys/kernel/nmi_watchdog > 0 > [root@jouet linux]# > > Please advise.

Re: [PATCH 1/4] perf stat: Basic support for TopDown in perf stat

2016-05-30 Thread Arnaldo Carvalho de Melo
Em Tue, May 24, 2016 at 12:52:36PM -0700, Andi Kleen escreveu: > From: Andi Kleen > > Add basic plumbing for TopDown in perf stat > > TopDown is intended to replace the frontend cycles idle/ > backend cycles idle metrics in standard perf stat output. > These metrics are not reliable in many work