Re: [PATCH 1/4] perf expr: Add parsing support for multiple expressions

2020-05-13 Thread Jiri Olsa
On Tue, May 12, 2020 at 11:50:18PM -0700, Ian Rogers wrote: > On Mon, May 11, 2020 at 1:54 PM Jiri Olsa wrote: > > > > Adding support to parse metric difinitions in following form: > > Typo on definitions. right SNIP > > +int expr__parse_custom(struct expr_parse_ctx *ctx, const char *expr) > >

Re: [PATCH 1/4] perf expr: Add parsing support for multiple expressions

2020-05-12 Thread Ian Rogers
On Mon, May 11, 2020 at 1:54 PM Jiri Olsa wrote: > > Adding support to parse metric difinitions in following form: Typo on definitions. > NAME = EXPRESSION ; > NAME = EXPRESSION ; > ... > > The parsed NAME and EXPRESSION will be used in following > changes to feed the metric code with defi