Re: [PATCH 1/4] lib/rhashtable: simplify bucket_table_alloc()

2018-06-21 Thread Davidlohr Bueso
On Fri, 22 Jun 2018, NeilBrown wrote: On Thu, Jun 21 2018, Davidlohr Bueso wrote: As of ce91f6ee5 (mm: kvmalloc does not fallback to vmalloc for incompatible gfp flag), we can simplify the caller and trust kvzalloc() to just do the right thing. Hi, it isn't clear to me that this is true. Wi

Re: [PATCH 1/4] lib/rhashtable: simplify bucket_table_alloc()

2018-06-21 Thread NeilBrown
On Thu, Jun 21 2018, Davidlohr Bueso wrote: > As of ce91f6ee5 (mm: kvmalloc does not fallback to vmalloc for incompatible > gfp flag), > we can simplify the caller and trust kvzalloc() to just do the right thing. Hi, it isn't clear to me that this is true. With this change we lose __GFP_NOWARN

Re: [PATCH 1/4] lib/rhashtable: simplify bucket_table_alloc()

2018-06-21 Thread Randy Dunlap
On 06/21/2018 02:28 PM, Davidlohr Bueso wrote: > As of ce91f6ee5 (mm: kvmalloc does not fallback to vmalloc for incompatible > gfp flag), > we can simplify the caller and trust kvzalloc() to just do the right thing. Hi, JFYI, we are using 12-digit (12-character) commit IDs nowadays... > Signed-