Re: [PATCH 1/4] fix not-and/or errors

2007-10-18 Thread Roel Kluin
previously applied changes removed and changed as suggested. Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/drivers/misc/asus-laptop.c b/drivers/misc/asus-laptop.c index 7dce318..752ae26 100644 --- a/drivers/misc/asus-laptop.c +++ b/drivers/misc/asus-laptop.c @@ -322,7 +322,7 @

Re: [PATCH 1/4] fix not-and/or errors

2007-10-18 Thread Roel Kluin
Al Viro wrote: > On Wed, Oct 17, 2007 at 03:46:43PM +0200, Roel Kluin wrote: >> +++ b/drivers/misc/asus-laptop.c >> @@ -322,7 +322,7 @@ static void write_status(acpi_handle handle, int out, >> int mask) >> >> switch (mask) { >> case MLED_ON: >> -out = !out & 0x1; >> +

Re: [PATCH 1/4] fix not-and/or errors

2007-10-17 Thread Al Viro
On Wed, Oct 17, 2007 at 03:46:43PM +0200, Roel Kluin wrote: > +++ b/drivers/misc/asus-laptop.c > @@ -322,7 +322,7 @@ static void write_status(acpi_handle handle, int out, int > mask) > > switch (mask) { > case MLED_ON: > - out = !out & 0x1; > + out = !(out & 0

Re: [PATCH 1/4] fix not-and/or errors

2007-10-17 Thread Andreas Schwab
Roel Kluin <[EMAIL PROTECTED]> writes: > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c > index 73c44cb..81943ef 100644 > --- a/drivers/scsi/st.c > +++ b/drivers/scsi/st.c > @@ -2882,7 +2882,7 @@ static int st_int_ioctl(struct scsi_tape *STp, unsigned > int cmd_in, unsigned lon >

Re: [PATCH 1/4] fix not-and/or errors

2007-10-17 Thread Peter Zijlstra
On Wed, 2007-10-17 at 15:46 +0200, Roel Kluin wrote: > if(!x & y) should either be if(!(x & y)) or if(!x && y) > I made changes as seemed appropriate, but please review > this is against current git. > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> Not being familiar with any of