Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs

2016-11-29 Thread David Matlack
On Tue, Nov 29, 2016 at 12:01 AM, Paolo Bonzini wrote: >> On Mon, Nov 28, 2016 at 2:48 PM, Paolo Bonzini wrote: >> > On 28/11/2016 22:11, David Matlack wrote: >> >> > PINBASED_CTLS, PROCBASED_CTLS, EXIT_CTLS and ENTRY_CTLS can be derived >> >> > from their "true" counterparts, so I think it's bet

Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs

2016-11-29 Thread Paolo Bonzini
> On Mon, Nov 28, 2016 at 2:48 PM, Paolo Bonzini wrote: > > On 28/11/2016 22:11, David Matlack wrote: > >> > PINBASED_CTLS, PROCBASED_CTLS, EXIT_CTLS and ENTRY_CTLS can be derived > >> > from their "true" counterparts, so I think it's better to remove the > >> > "non-true" ones from struct nested_

Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs

2016-11-28 Thread David Matlack
On Mon, Nov 28, 2016 at 2:48 PM, Paolo Bonzini wrote: > On 28/11/2016 22:11, David Matlack wrote: >> > PINBASED_CTLS, PROCBASED_CTLS, EXIT_CTLS and ENTRY_CTLS can be derived >> > from their "true" counterparts, so I think it's better to remove the >> > "non-true" ones from struct nested_vmx (and/o

Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs

2016-11-28 Thread Paolo Bonzini
On 28/11/2016 22:11, David Matlack wrote: > > PINBASED_CTLS, PROCBASED_CTLS, EXIT_CTLS and ENTRY_CTLS can be derived > > from their "true" counterparts, so I think it's better to remove the > > "non-true" ones from struct nested_vmx (and/or add the "true" ones when > > missing) and make them enti

Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs

2016-11-28 Thread David Matlack
On Wed, Nov 23, 2016 at 3:44 AM, Paolo Bonzini wrote: > On 23/11/2016 02:14, David Matlack wrote: >> switch (msr_index) { >> case MSR_IA32_VMX_BASIC: >> + return vmx_restore_vmx_basic(vmx, data); >> + case MSR_IA32_VMX_TRUE_PINBASED_CTLS: >> + case MSR_IA32_VMX_PINB

Re: [PATCH 1/4] KVM: nVMX: support restore of VMX capability MSRs

2016-11-23 Thread Paolo Bonzini
On 23/11/2016 02:14, David Matlack wrote: > The VMX capability MSRs advertise the set of features the KVM virtual > CPU can support. This set of features vary across different host CPUs > and KVM versions. This patch aims to addresses both sources of > differences, allowing VMs to be migrated acr