Re: [PATCH 1/38] KVM: Create kvm-intel.ko module

2006-11-30 Thread Ingo Molnar
* Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Thu, Nov 30, 2006 at 09:19:35PM +0100, Ingo Molnar wrote: > > > I get the feeling we'd be best off if we were to revisit this in a > > > year or so. > > > > yeah. I'd suggest merging it as-is into v2.6.20. In a year we'll > > have some real A

Re: [PATCH 1/38] KVM: Create kvm-intel.ko module

2006-11-30 Thread Christoph Hellwig
On Thu, Nov 30, 2006 at 09:19:35PM +0100, Ingo Molnar wrote: > > I get the feeling we'd be best off if we were to revisit this in a > > year or so. > > yeah. I'd suggest merging it as-is into v2.6.20. In a year we'll have > some real APIs to think about. Agreed. And because of that I think kee

Re: [PATCH 1/38] KVM: Create kvm-intel.ko module

2006-11-30 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > It's a fat, complex, presumably arch-specific, presumably > frequently-changing API. So whatever we do will be unpleasant - > that's unavoidable in this case, I suspect. > > (hmm, the interface isn't versioned at present - should it be?) > > Maybe

Re: [PATCH 1/38] KVM: Create kvm-intel.ko module

2006-11-30 Thread Andrew Morton
On Thu, 30 Nov 2006 16:44:25 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > [...] Pretty similar to things like the msr or mtrr driver that expose > > cpu features as character drivers aswell. > > you can expose everything as character drivers and ioctls, but that > doesnt make it the right s

Re: [PATCH 1/38] KVM: Create kvm-intel.ko module

2006-11-30 Thread Ingo Molnar
* Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > please move this from drivers/kvm/ to kernel/kvm/ [or even into a > > toplevel kvm/ directory] - KVM is not a "driver", KVM enhances the > > core Linux kernel with hypervisor functionality. > > Actually it's exactly a driver. It's a character

Re: [PATCH 1/38] KVM: Create kvm-intel.ko module

2006-11-30 Thread Christoph Hellwig
On Mon, Nov 27, 2006 at 01:36:06PM +0100, Ingo Molnar wrote: > > * Avi Kivity <[EMAIL PROTECTED]> wrote: > > > --- linux-2.6.orig/drivers/kvm/kvm.h > > +++ linux-2.6/drivers/kvm/kvm.h > > please move this from drivers/kvm/ to kernel/kvm/ [or even into a > toplevel kvm/ directory] - KVM is not a

Re: [PATCH 1/38] KVM: Create kvm-intel.ko module

2006-11-28 Thread Ingo Molnar
* Avi Kivity <[EMAIL PROTECTED]> wrote: > --- linux-2.6.orig/drivers/kvm/kvm.h > +++ linux-2.6/drivers/kvm/kvm.h please move this from drivers/kvm/ to kernel/kvm/ [or even into a toplevel kvm/ directory] - KVM is not a "driver", KVM enhances the core Linux kernel with hypervisor functionality.