Re: [PATCH 1/3] perf header: Add die information in CPU topology

2019-05-28 Thread Jiri Olsa
On Tue, May 28, 2019 at 03:06:16PM -0400, Liang, Kan wrote: > > > On 5/28/2019 5:00 AM, Jiri Olsa wrote: > > On Thu, May 23, 2019 at 01:41:19PM -0700, kan.li...@linux.intel.com wrote: > > > > SNIP > > > > > diff --git a/tools/perf/util/cputopo.c b/tools/perf/util/cputopo.c > > > index ece0710..

Re: [PATCH 1/3] perf header: Add die information in CPU topology

2019-05-28 Thread Liang, Kan
On 5/28/2019 5:00 AM, Jiri Olsa wrote: On Thu, May 23, 2019 at 01:41:19PM -0700, kan.li...@linux.intel.com wrote: SNIP diff --git a/tools/perf/util/cputopo.c b/tools/perf/util/cputopo.c index ece0710..f6e7db7 100644 --- a/tools/perf/util/cputopo.c +++ b/tools/perf/util/cputopo.c @@ -1,5 +1,

Re: [PATCH 1/3] perf header: Add die information in CPU topology

2019-05-28 Thread Jiri Olsa
On Thu, May 23, 2019 at 01:41:19PM -0700, kan.li...@linux.intel.com wrote: SNIP > @@ -88,7 +138,7 @@ static int build_cpu_topology(struct cpu_topology *tp, int > cpu) > return ret; > } > > -void cpu_topology__delete(struct cpu_topology *tp) > +void cpu_topology__delete(struct cpu_topolo

Re: [PATCH 1/3] perf header: Add die information in CPU topology

2019-05-28 Thread Jiri Olsa
On Thu, May 23, 2019 at 01:41:19PM -0700, kan.li...@linux.intel.com wrote: SNIP > diff --git a/tools/perf/util/cputopo.c b/tools/perf/util/cputopo.c > index ece0710..f6e7db7 100644 > --- a/tools/perf/util/cputopo.c > +++ b/tools/perf/util/cputopo.c > @@ -1,5 +1,6 @@ > // SPDX-License-Identifier:

Re: [PATCH 1/3] perf header: Add die information in CPU topology

2019-05-28 Thread Jiri Olsa
On Thu, May 23, 2019 at 01:41:19PM -0700, kan.li...@linux.intel.com wrote: > From: Kan Liang > > With the new CPUID.1F, a new level type of CPU topology, 'die', is > introduced. The 'die' information in CPU topology should be added in > perf header. > > To be compatible with old perf.data, the p

Re: [PATCH 1/3] perf header: Add die information in CPU topology

2019-05-28 Thread Jiri Olsa
On Thu, May 23, 2019 at 01:41:19PM -0700, kan.li...@linux.intel.com wrote: SNIP > > Add cpu_map__get_die_id() in cpumap.c to fetch die id information. > > Signed-off-by: Kan Liang > --- > tools/perf/Documentation/perf.data-file-format.txt | 9 +- > tools/perf/util/cpumap.c

Re: [PATCH 1/3] perf header: Add die information in CPU topology

2019-05-28 Thread Jiri Olsa
On Thu, May 23, 2019 at 01:41:19PM -0700, kan.li...@linux.intel.com wrote: SNIP > if (sret <= 0) > - goto try_threads; > + goto try_dies; > > p = strchr(buf, '\n'); > if (p) > @@ -57,6 +78,35 @@ static int build_cpu_topology(struct cpu_topology *tp, int