Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-02-03 Thread Paul E. McKenney
On Mon, Feb 01, 2021 at 12:47:55PM +0100, Michal Hocko wrote: > On Fri 29-01-21 17:35:31, Uladzislau Rezki wrote: > > On Fri, Jan 29, 2021 at 09:56:29AM +0100, Michal Hocko wrote: > > > On Thu 28-01-21 19:02:37, Uladzislau Rezki wrote: > > > [...] > > > > >From 0bdb8ca1ae62088790e0a452c4acec3821e06

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-02-01 Thread Uladzislau Rezki
On Mon, Feb 01, 2021 at 12:47:55PM +0100, Michal Hocko wrote: > On Fri 29-01-21 17:35:31, Uladzislau Rezki wrote: > > On Fri, Jan 29, 2021 at 09:56:29AM +0100, Michal Hocko wrote: > > > On Thu 28-01-21 19:02:37, Uladzislau Rezki wrote: > > > [...] > > > > >From 0bdb8ca1ae62088790e0a452c4acec3821e06

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-02-01 Thread Michal Hocko
On Fri 29-01-21 17:35:31, Uladzislau Rezki wrote: > On Fri, Jan 29, 2021 at 09:56:29AM +0100, Michal Hocko wrote: > > On Thu 28-01-21 19:02:37, Uladzislau Rezki wrote: > > [...] > > > >From 0bdb8ca1ae62088790e0a452c4acec3821e06989 Mon Sep 17 00:00:00 2001 > > > From: "Uladzislau Rezki (Sony)" > >

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-29 Thread Uladzislau Rezki
On Fri, Jan 29, 2021 at 09:56:29AM +0100, Michal Hocko wrote: > On Thu 28-01-21 19:02:37, Uladzislau Rezki wrote: > [...] > > >From 0bdb8ca1ae62088790e0a452c4acec3821e06989 Mon Sep 17 00:00:00 2001 > > From: "Uladzislau Rezki (Sony)" > > Date: Wed, 20 Jan 2021 17:21:46 +0100 > > Subject: [PATCH v2

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-28 Thread Uladzislau Rezki
On Thu, Jan 28, 2021 at 04:30:17PM +0100, Uladzislau Rezki wrote: > On Thu, Jan 28, 2021 at 04:17:01PM +0100, Michal Hocko wrote: > > On Thu 28-01-21 16:11:52, Uladzislau Rezki wrote: > > > On Mon, Jan 25, 2021 at 05:25:59PM +0100, Uladzislau Rezki wrote: > > > > On Mon, Jan 25, 2021 at 04:39:43PM

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-28 Thread Uladzislau Rezki
On Thu, Jan 28, 2021 at 04:17:01PM +0100, Michal Hocko wrote: > On Thu 28-01-21 16:11:52, Uladzislau Rezki wrote: > > On Mon, Jan 25, 2021 at 05:25:59PM +0100, Uladzislau Rezki wrote: > > > On Mon, Jan 25, 2021 at 04:39:43PM +0100, Michal Hocko wrote: > > > > On Mon 25-01-21 15:31:50, Uladzislau Re

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-28 Thread Michal Hocko
On Thu 28-01-21 16:11:52, Uladzislau Rezki wrote: > On Mon, Jan 25, 2021 at 05:25:59PM +0100, Uladzislau Rezki wrote: > > On Mon, Jan 25, 2021 at 04:39:43PM +0100, Michal Hocko wrote: > > > On Mon 25-01-21 15:31:50, Uladzislau Rezki wrote: > > > > > On Wed 20-01-21 17:21:46, Uladzislau Rezki (Sony)

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-28 Thread Uladzislau Rezki
On Mon, Jan 25, 2021 at 05:25:59PM +0100, Uladzislau Rezki wrote: > On Mon, Jan 25, 2021 at 04:39:43PM +0100, Michal Hocko wrote: > > On Mon 25-01-21 15:31:50, Uladzislau Rezki wrote: > > > > On Wed 20-01-21 17:21:46, Uladzislau Rezki (Sony) wrote: > > > > > For a single argument we can directly re

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-25 Thread Uladzislau Rezki
On Mon, Jan 25, 2021 at 04:39:43PM +0100, Michal Hocko wrote: > On Mon 25-01-21 15:31:50, Uladzislau Rezki wrote: > > > On Wed 20-01-21 17:21:46, Uladzislau Rezki (Sony) wrote: > > > > For a single argument we can directly request a page from a caller > > > > context when a "carry page block" is ru

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-25 Thread Michal Hocko
On Mon 25-01-21 15:31:50, Uladzislau Rezki wrote: > > On Wed 20-01-21 17:21:46, Uladzislau Rezki (Sony) wrote: > > > For a single argument we can directly request a page from a caller > > > context when a "carry page block" is run out of free spots. Instead > > > of hitting a slow path we can reque

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-25 Thread Uladzislau Rezki
> On Wed 20-01-21 17:21:46, Uladzislau Rezki (Sony) wrote: > > For a single argument we can directly request a page from a caller > > context when a "carry page block" is run out of free spots. Instead > > of hitting a slow path we can request an extra page by demand and > > proceed with a fast pat

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-25 Thread Michal Hocko
On Wed 20-01-21 17:21:46, Uladzislau Rezki (Sony) wrote: > For a single argument we can directly request a page from a caller > context when a "carry page block" is run out of free spots. Instead > of hitting a slow path we can request an extra page by demand and > proceed with a fast path. > > A

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-22 Thread Uladzislau Rezki
> On 2021-01-21 13:38:34 [+0100], Uladzislau Rezki wrote: > > __get_free_page() returns "unsigned long" whereas a bnode is a pointer > > to kvfree_rcu_bulk_data struct, without a casting the compiler will > > emit a warning. > > Yes, learned about it, sorry. > > > >> You think that a CPU migratio

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-22 Thread Paul E. McKenney
On Fri, Jan 22, 2021 at 12:17:33PM +0100, Sebastian Andrzej Siewior wrote: > On 2021-01-20 13:54:03 [-0800], Paul E. McKenney wrote: > > > > +// Record ptr in a page managed by krcp, with the > > > > pre-krc_this_cpu_lock() > > > > +// state specified by flags. If can_alloc is true, the caller mu

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-22 Thread Sebastian Andrzej Siewior
On 2021-01-20 13:54:03 [-0800], Paul E. McKenney wrote: > > > +// Record ptr in a page managed by krcp, with the pre-krc_this_cpu_lock() > > > +// state specified by flags. If can_alloc is true, the caller must > > > +// be schedulable and not be holding any locks or mutexes that might be > > > +/

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-22 Thread Sebastian Andrzej Siewior
On 2021-01-21 13:38:34 [+0100], Uladzislau Rezki wrote: > __get_free_page() returns "unsigned long" whereas a bnode is a pointer > to kvfree_rcu_bulk_data struct, without a casting the compiler will > emit a warning. Yes, learned about it, sorry. > >> You think that a CPU migration is a bad thing

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-21 Thread Uladzislau Rezki
On Thu, Jan 21, 2021 at 07:07:40AM -0800, Paul E. McKenney wrote: > On Thu, Jan 21, 2021 at 02:35:10PM +0100, Uladzislau Rezki wrote: > > On Wed, Jan 20, 2021 at 01:54:03PM -0800, Paul E. McKenney wrote: > > > On Wed, Jan 20, 2021 at 08:57:57PM +0100, Sebastian Andrzej Siewior wrote: > > [ . . . ]

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-21 Thread Paul E. McKenney
On Thu, Jan 21, 2021 at 02:35:10PM +0100, Uladzislau Rezki wrote: > On Wed, Jan 20, 2021 at 01:54:03PM -0800, Paul E. McKenney wrote: > > On Wed, Jan 20, 2021 at 08:57:57PM +0100, Sebastian Andrzej Siewior wrote: [ . . . ] > > > so if bnode is NULL you could retry get_cached_bnode() since it migh

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-21 Thread Uladzislau Rezki
On Wed, Jan 20, 2021 at 01:54:03PM -0800, Paul E. McKenney wrote: > On Wed, Jan 20, 2021 at 08:57:57PM +0100, Sebastian Andrzej Siewior wrote: > > On 2021-01-20 17:21:46 [+0100], Uladzislau Rezki (Sony) wrote: > > > For a single argument we can directly request a page from a caller > > > context wh

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-21 Thread Uladzislau Rezki
On Wed, Jan 20, 2021 at 08:57:57PM +0100, Sebastian Andrzej Siewior wrote: > On 2021-01-20 17:21:46 [+0100], Uladzislau Rezki (Sony) wrote: > > For a single argument we can directly request a page from a caller > > context when a "carry page block" is run out of free spots. Instead > > of hitting a

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-20 Thread Paul E. McKenney
On Wed, Jan 20, 2021 at 08:57:57PM +0100, Sebastian Andrzej Siewior wrote: > On 2021-01-20 17:21:46 [+0100], Uladzislau Rezki (Sony) wrote: > > For a single argument we can directly request a page from a caller > > context when a "carry page block" is run out of free spots. Instead > > of hitting a

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-20 Thread Sebastian Andrzej Siewior
On 2021-01-20 17:21:46 [+0100], Uladzislau Rezki (Sony) wrote: > For a single argument we can directly request a page from a caller > context when a "carry page block" is run out of free spots. Instead > of hitting a slow path we can request an extra page by demand and > proceed with a fast path. >

Re: [PATCH 1/3] kvfree_rcu: Allocate a page for a single argument

2021-01-20 Thread Paul E. McKenney
On Wed, Jan 20, 2021 at 05:21:46PM +0100, Uladzislau Rezki (Sony) wrote: > For a single argument we can directly request a page from a caller > context when a "carry page block" is run out of free spots. Instead > of hitting a slow path we can request an extra page by demand and > proceed with a fa