Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-02 Thread Matt Domsch
On Wed, Jan 02, 2008 at 11:45:17PM +0100, Bartlomiej Zolnierkiewicz wrote: > Unfortunately 'srcversion' is set only if MODULE_VERSION() is used... :( or CONFIG_MODULE_SRCVERSION_ALL=y. I see Fedora doesn't use that :-( but Ubuntu, openSUSE do. /me files a change request... -- Matt Domsch Linux

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-02 Thread Bartlomiej Zolnierkiewicz
On Wednesday 02 January 2008, Matt Domsch wrote: > On Tue, Jan 01, 2008 at 09:32:36PM -0500, Jon Masters wrote: > > On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: > > > > > On the second thought: maybe we will be better off with limiting > > > MODULE_VERSION() to the device dr

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-02 Thread Stefan Richter
Jon Masters wrote: > On Tue, 2008-01-01 at 22:46 -0600, Matt Domsch wrote: >> $ modinfo dell_rbu | grep version >> version:3.2 >> srcversion: 1D4815D7D6FBEE6612F3C18 > > Right. And I was referring to the is above (I forgot it's a CRC32 and > not a SHA1). But my point is why not codify

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Jon Masters
On Tue, 2008-01-01 at 22:46 -0600, Matt Domsch wrote: > On Tue, Jan 01, 2008 at 09:32:36PM -0500, Jon Masters wrote: > > On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: > > > > > On the second thought: maybe we will be better off with limiting > > > MODULE_VERSION() to the dev

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Matt Domsch
On Tue, Jan 01, 2008 at 09:32:36PM -0500, Jon Masters wrote: > On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: > > > On the second thought: maybe we will be better off with limiting > > MODULE_VERSION() to the device drivers and the IDE core module for now, > > and just removin

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Jon Masters
On Tue, 2008-01-01 at 19:33 +0100, Bartlomiej Zolnierkiewicz wrote: > On the second thought: maybe we will be better off with limiting > MODULE_VERSION() to the device drivers and the IDE core module for now, > and just removing all these private version numbers from host drivers > (with one or tw

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Bartlomiej Zolnierkiewicz
On Tuesday 01 January 2008, Adrian Bunk wrote: > On Tue, Jan 01, 2008 at 06:40:38PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > * Replace driver versions in comments by DRV_VERSION define. > > > > * Add MODULE_VERSION(DRV_VERSION) to drivers defining DRV_VERSION. > >... > > Could you limit t

Re: [PATCH 1/3] ide: use MODULE_VERSION()

2008-01-01 Thread Adrian Bunk
On Tue, Jan 01, 2008 at 06:40:38PM +0100, Bartlomiej Zolnierkiewicz wrote: > > * Replace driver versions in comments by DRV_VERSION define. > > * Add MODULE_VERSION(DRV_VERSION) to drivers defining DRV_VERSION. >... Could you limit this to actively maintained version numbers and also remove the