Re: [PATCH 1/3] fpga manager framework core

Hi! > + nr = ida_simple_get(&fpga_mgr_ida, start, FPGA_MAX_MINORS, GFP_KERNEL); > + Actually, are you sure ida framework is a good idea here? AFAICT, you only use it to keep track of used minors. pavel -- (english) http://www.

Re: [PATCH 1/3] fpga manager framework core

Hi! > +static int fpga_mgr_get_new_minor(struct fpga_manager *mgr, int request_nr) > +{ > + int nr, start; > + > + /* check specified minor number */ > + if (request_nr >= FPGA_MAX_MINORS) { > + dev_err(mgr->parent, "Out of device minors (%d)\n", request_nr); > +