Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3

2017-09-03 Thread Maxime Ripard
On Fri, Sep 01, 2017 at 02:42:47PM +, Brüns, Stefan wrote: > On Freitag, 1. September 2017 15:35:49 CEST Maxime Ripard wrote: > > On Fri, Sep 01, 2017 at 05:04:54AM +0200, Stefan Bruens wrote: > > > On Donnerstag, 31. August 2017 16:51:35 CEST Maxime Ripard wrote: > > > > Hi, > > > > > > > > O

Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3

2017-09-01 Thread Brüns , Stefan
On Freitag, 1. September 2017 15:35:49 CEST Maxime Ripard wrote: > On Fri, Sep 01, 2017 at 05:04:54AM +0200, Stefan Bruens wrote: > > On Donnerstag, 31. August 2017 16:51:35 CEST Maxime Ripard wrote: > > > Hi, > > > > > > On Thu, Aug 31, 2017 at 01:36:07AM +0200, Stefan Brüns wrote: > > > > +/* Be

Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3

2017-09-01 Thread Maxime Ripard
On Fri, Sep 01, 2017 at 05:04:54AM +0200, Stefan Bruens wrote: > On Donnerstag, 31. August 2017 16:51:35 CEST Maxime Ripard wrote: > > Hi, > > > > On Thu, Aug 31, 2017 at 01:36:07AM +0200, Stefan Brüns wrote: > > > +/* Between SoC generations, there are some significant differences: > > > + * - A2

Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3

2017-08-31 Thread Stefan Bruens
On Donnerstag, 31. August 2017 16:51:35 CEST Maxime Ripard wrote: > Hi, > > On Thu, Aug 31, 2017 at 01:36:07AM +0200, Stefan Brüns wrote: > > +/* Between SoC generations, there are some significant differences: > > + * - A23 added a clock gate register > > + * - the H3 burst length field has a dif

Re: [PATCH 1/3] dmaengine: sun6i: Correct DMA support on H3

2017-08-31 Thread Maxime Ripard
Hi, On Thu, Aug 31, 2017 at 01:36:07AM +0200, Stefan Brüns wrote: > +/* Between SoC generations, there are some significant differences: > + * - A23 added a clock gate register > + * - the H3 burst length field has a different offset > + */ This is not the proper comment style. > +enum dmac_vari