Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

2019-10-18 Thread Andi Kleen
On Fri, Oct 18, 2019 at 08:33:26AM -0700, Joe Perches wrote: > On Fri, 2019-10-18 at 17:08 +0200, Miguel Ojeda wrote: > > On Thu, Oct 17, 2019 at 10:07 AM Lars Poeschel wrote: > [] > > > Oh by the way: Do you know what I can do to make checkpatch happy with > > > its describing of the config symbo

Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

2019-10-18 Thread Joe Perches
On Fri, 2019-10-18 at 17:08 +0200, Miguel Ojeda wrote: > On Thu, Oct 17, 2019 at 10:07 AM Lars Poeschel wrote: [] > > Oh by the way: Do you know what I can do to make checkpatch happy with > > its describing of the config symbol ? I tried writing a help paragraph > > for the config symbols in Kcon

Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

2019-10-18 Thread Miguel Ojeda
On Thu, Oct 17, 2019 at 10:07 AM Lars Poeschel wrote: > > That panel.c doesn't compile is of course a no-go. Sorry. I missed > something and I will fix this in a next version of the patch. But before > submitting a next version, I will wait some time, if there is more > feedback. I meant I wasn't

Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

2019-10-17 Thread Andy Shevchenko
On Thu, Oct 17, 2019 at 11:07 AM Lars Poeschel wrote: > On Wed, Oct 16, 2019 at 06:53:20PM +0200, Miguel Ojeda wrote: > > On Wed, Oct 16, 2019 at 10:24 AM Lars Poeschel wrote: > > Thanks Lars, CC'ing Geert since he wrote a large portion of this, as > > well as Andy. I would be able to test next

Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

2019-10-17 Thread Lars Poeschel
On Wed, Oct 16, 2019 at 06:53:20PM +0200, Miguel Ojeda wrote: > On Wed, Oct 16, 2019 at 10:24 AM Lars Poeschel wrote: > > > > charlcd.c contains lots of hd44780 hardware specific stuff. It is nearly > > impossible to reuse the interface for other character based displays. > > The current users of

Re: [PATCH 1/3] auxdisplay: Make charlcd.[ch] more general

2019-10-16 Thread Miguel Ojeda
On Wed, Oct 16, 2019 at 10:24 AM Lars Poeschel wrote: > > charlcd.c contains lots of hd44780 hardware specific stuff. It is nearly > impossible to reuse the interface for other character based displays. > The current users of charlcd are the hd44780 and the panel drivers. > This does factor out th