Re: [PATCH 1/3] ARM: mach-moxart: add MOXA ART SoC files

2013-06-17 Thread Olof Johansson
Hi, On Fri, Jun 14, 2013 at 04:33:29PM +0200, Jonas Jensen wrote: > Hi, > > Thanks for the replies. > > What isn't commented below should already be fixed. I'll resubmit the > entire set when it looks like there's nothing left to amend. > > On 13 June 2013 00:42, Olof Johansson wrote: > > You

Re: [PATCH 1/3] ARM: mach-moxart: add MOXA ART SoC files

2013-06-14 Thread Arnd Bergmann
On Friday 14 June 2013 09:41:36 Olof Johansson wrote: > I sort of presumed that there might be need for _some_ platform code > later on, just not quite yet, so I didn't want to be quite that > drastic. I suppose leaving it with the trivial file for now is OK, and > we can make a sweeping change dow

Re: [PATCH 1/3] ARM: mach-moxart: add MOXA ART SoC files

2013-06-14 Thread Olof Johansson
On Fri, Jun 14, 2013 at 7:47 AM, Arnd Bergmann wrote: arch.h> >> + >> +static const char * const moxart_dt_compat[] = { >> + "moxa,moxart-uc-7112-lx", >> + NULL, >> +}; >> + >> +DT_MACHINE_START(MOXART, "MOXA UC-7112-LX") >> + .dt_compat = moxart_dt_compat, >> +MACHINE_END

Re: [PATCH 1/3] ARM: mach-moxart: add MOXA ART SoC files

2013-06-14 Thread Arnd Bergmann
On Wednesday 12 June 2013 14:34:06 Jonas Jensen wrote: > diff --git a/arch/arm/mach-moxart/idle.c b/arch/arm/mach-moxart/idle.c > new file mode 100644 > index 000..73ed844 > --- /dev/null > +++ b/arch/arm/mach-moxart/idle.c > @@ -0,0 +1,21 @@ > +/* Copyright (C) 2013 Jonas Jensen > + * This p

Re: [PATCH 1/3] ARM: mach-moxart: add MOXA ART SoC files

2013-06-14 Thread Jonas Jensen
Hi, Thanks for the replies. What isn't commented below should already be fixed. I'll resubmit the entire set when it looks like there's nothing left to amend. On 13 June 2013 00:42, Olof Johansson wrote: > You should provide a commit message, ideally with a short introduction of the > platform.

Re: [PATCH 1/3] ARM: mach-moxart: add MOXA ART SoC files

2013-06-12 Thread Olof Johansson
Hi, This looks pretty good. I have mostly a bunch of nits below. Please feel free to cc a...@kernel.org (which goes to us arm-soc maintainers) on future postings. On Wed, Jun 12, 2013 at 02:34:06PM +0200, Jonas Jensen wrote: > > Signed-off-by: Jonas Jensen You should provide a commit message