Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters

2017-08-14 Thread Michal Simek
On 14.8.2017 16:47, Guenter Roeck wrote: > On Fri, Aug 04, 2017 at 09:39:16AM +0200, Michal Simek wrote: >> Give read access to module parameters to all and write access to root. >> This change also improves driver error path testing. >> >> Signed-off-by: Michal Simek > > Reviewed-by: Guenter Roe

Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters

2017-08-14 Thread Guenter Roeck
On Fri, Aug 04, 2017 at 09:39:16AM +0200, Michal Simek wrote: > Give read access to module parameters to all and write access to root. > This change also improves driver error path testing. > > Signed-off-by: Michal Simek Reviewed-by: Guenter Roeck > --- > > Please let me know what you think

Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters

2017-08-04 Thread Michal Simek
On 4.8.2017 15:45, Guenter Roeck wrote: > On 08/04/2017 12:39 AM, Michal Simek wrote: >> Give read access to module parameters to all and write access to root. >> This change also improves driver error path testing. >> >> Signed-off-by: Michal Simek >> --- >> >> Please let me know what you think -

Re: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters

2017-08-04 Thread Guenter Roeck
On 08/04/2017 12:39 AM, Michal Simek wrote: Give read access to module parameters to all and write access to root. This change also improves driver error path testing. Signed-off-by: Michal Simek --- Please let me know what you think - I can use macros from stat.h if required Seems to be qu