Re: [PATCH 1/2] rtc: mxc: add a second clock

2015-06-04 Thread Alexandre Belloni
On 04/06/2015 at 23:08:03 +0200, Philippe Reynes wrote : > >You are getting the rate but don't you need to clk_prepare_enable()? > > This IP needs the clock reference rate for his configuration, > so I think that I only need the rate. > I think we need to check whether we are guaranteed to get a

Re: [PATCH 1/2] rtc: mxc: add a second clock

2015-06-04 Thread Philippe Reynes
Hi Alexandre, On 28/05/15 13:57, Alexandre Belloni wrote: Hi, On 16/05/2015 at 00:35:29 +0200, Philippe Reynes wrote : The mxc RTC needs two clocks, one for the input reference, and one for the IP. But this driver was only using one clock (for the reference). This patch add the second clock (f

Re: [PATCH 1/2] rtc: mxc: add a second clock

2015-05-28 Thread Alexandre Belloni
Hi, On 16/05/2015 at 00:35:29 +0200, Philippe Reynes wrote : > The mxc RTC needs two clocks, one for the input > reference, and one for the IP. But this driver > was only using one clock (for the reference). > This patch add the second clock (for the IP). > > Signed-off-by: Philippe Reynes > ---

Re: [PATCH 1/2] rtc: mxc: add a second clock

2015-05-18 Thread Shawn Guo
On Sat, May 16, 2015 at 12:35:29AM +0200, Philippe Reynes wrote: > The mxc RTC needs two clocks, one for the input > reference, and one for the IP. But this driver > was only using one clock (for the reference). > This patch add the second clock (for the IP). > > Signed-off-by: Philippe Reynes >

Re: [PATCH 1/2] rtc: mxc: add a second clock

2015-05-18 Thread Philippe Reynes
Hi Enrico, On 18/05/15 13:27, Enrico Weigelt, metux IT consult wrote: Am 16.05.2015 um 00:35 schrieb Philippe Reynes: The mxc RTC needs two clocks, one for the input reference, and one for the IP. But this driver was only using one clock (for the reference). This patch add the second clock (for

Re: [PATCH 1/2] rtc: mxc: add a second clock

2015-05-18 Thread Enrico Weigelt, metux IT consult
Am 16.05.2015 um 00:35 schrieb Philippe Reynes: The mxc RTC needs two clocks, one for the input reference, and one for the IP. But this driver was only using one clock (for the reference). This patch add the second clock (for the IP). Does this also apply to MX53, or just MX21 ? greetings, -