Re: [PATCH 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP

2016-03-01 Thread Laxman Dewangan
On Wednesday 02 March 2016 09:58 AM, Krzysztof Kozlowski wrote: On 02.03.2016 13:10, Laxman Dewangan wrote: On Wednesday 02 March 2016 09:22 AM, Krzysztof Kozlowski wrote: On 02.03.2016 11:15, Laxman Dewangan wrote: (kernel_ulong_t)&max77802_drv_data, }, +{ "max77620-rtc", .driver_data =

Re: [PATCH 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP

2016-03-01 Thread Krzysztof Kozlowski
On 02.03.2016 13:10, Laxman Dewangan wrote: > > On Wednesday 02 March 2016 09:22 AM, Krzysztof Kozlowski wrote: >> On 02.03.2016 11:15, Laxman Dewangan wrote: >> > (kernel_ulong_t)&max77802_drv_data, }, > +{ "max77620-rtc", .driver_data = > (kernel_ulong_t)&max77620_drv_data, }, >>

Re: [PATCH 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP

2016-03-01 Thread Laxman Dewangan
On Wednesday 02 March 2016 09:22 AM, Krzysztof Kozlowski wrote: On 02.03.2016 11:15, Laxman Dewangan wrote: (kernel_ulong_t)&max77802_drv_data, }, +{ "max77620-rtc", .driver_data = (kernel_ulong_t)&max77620_drv_data, }, +{ "max20024-rtc", .driver_data = (kernel_ulong_t)&max77620_drv_da

Re: [PATCH 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP

2016-03-01 Thread Krzysztof Kozlowski
On 02.03.2016 11:15, Laxman Dewangan wrote: > > On Wednesday 02 March 2016 06:28 AM, Krzysztof Kozlowski wrote: >> On 29.02.2016 21:58, Laxman Dewangan wrote: >> +.alarm_pending_status_reg = MAX77620_RTC_ALARM_PENDING_STATUS_REG, >> Just skip the alarm_pending_status_reg (so it will be 0x0) an

Re: [PATCH 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP

2016-03-01 Thread Laxman Dewangan
On Wednesday 02 March 2016 06:28 AM, Krzysztof Kozlowski wrote: On 29.02.2016 21:58, Laxman Dewangan wrote: + .alarm_pending_status_reg = MAX77620_RTC_ALARM_PENDING_STATUS_REG, Just skip the alarm_pending_status_reg (so it will be 0x0) and check for non-zero value later? It might be a lit

Re: [PATCH 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP

2016-03-01 Thread Krzysztof Kozlowski
On 29.02.2016 21:58, Laxman Dewangan wrote: > Maxim Semiconductor's PMIC MAX77686 has RTC IP which is > reused in the MAX77620/MAX20024 PMICs. > > Add support for these devices in MAX77686 RTC driver. This > device does not have RTC alarm pending status outside of > RTC IP. The RTC IP is having se