Re: [PATCH 1/2] nfsd: Remove unnecessary assignment in nfs4xdr.c

2020-08-26 Thread J. Bruce Fields
On Fri, Aug 21, 2020 at 12:37:45AM +0100, Alex Dewar wrote: > On Wed, Aug 12, 2020 at 08:36:31PM +, Frank van der Linden wrote: > > On Wed, Aug 12, 2020 at 03:12:51PM +0100, Alex Dewar wrote: > > > > > > In nfsd4_encode_listxattrs(), the variable p is assigned to at one point > > > but this va

Re: [PATCH 1/2] nfsd: Remove unnecessary assignment in nfs4xdr.c

2020-08-20 Thread Alex Dewar
On Wed, Aug 12, 2020 at 08:36:31PM +, Frank van der Linden wrote: > On Wed, Aug 12, 2020 at 03:12:51PM +0100, Alex Dewar wrote: > > > > In nfsd4_encode_listxattrs(), the variable p is assigned to at one point > > but this value is never used before p is reassigned. Fix this. > > > > Addresses

Re: [PATCH 1/2] nfsd: Remove unnecessary assignment in nfs4xdr.c

2020-08-13 Thread Chuck Lever
> On Aug 12, 2020, at 4:36 PM, Frank van der Linden wrote: > > On Wed, Aug 12, 2020 at 03:12:51PM +0100, Alex Dewar wrote: >> >> In nfsd4_encode_listxattrs(), the variable p is assigned to at one point >> but this value is never used before p is reassigned. Fix this. >> >> Addresses-Coverity

Re: [PATCH 1/2] nfsd: Remove unnecessary assignment in nfs4xdr.c

2020-08-12 Thread Frank van der Linden
On Wed, Aug 12, 2020 at 03:12:51PM +0100, Alex Dewar wrote: > > In nfsd4_encode_listxattrs(), the variable p is assigned to at one point > but this value is never used before p is reassigned. Fix this. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Alex Dewar > --- > fs/nfsd/nfs4xdr.