Re: [PATCH 1/2] mm: Rename ambiguously named memory.stat counters and functions

2019-01-23 Thread Chris Down
Roman Gushchin writes: I'd personally go with memcg_vmstat_percpu. Not insisting, but you end up using both vmstat and vmstats, which isn't very consistent. Yeah, we also have similar naming in accumulated_vmstats. Hmm, let me think about this a bit and get back to you tomorrow. The main bit I

Re: [PATCH 1/2] mm: Rename ambiguously named memory.stat counters and functions

2019-01-23 Thread Roman Gushchin
On Wed, Jan 23, 2019 at 05:30:49PM -0500, Chris Down wrote: > I spent literally an hour trying to work out why an earlier version of > my memory.events aggregation code doesn't work properly, only to find > out I was calling memcg->events instead of memcg->memory_events, which > is fairly confusing