Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-05-10 Thread Ivan T. Ivanov
Hi Courtney, On Fri, 2014-05-09 at 13:30 -0700, Courtney Cavin wrote: > > > Requiring a specific PMIC listed before a generic one allows us an > > > escape hatch in the future if for some reason we need to add a quirk for > > > a specific PMIC. > > > > Is there a conclusion on this issue? I am

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-05-09 Thread Courtney Cavin
On Fri, May 09, 2014 at 02:45:30PM +0200, Ivan T. Ivanov wrote: [...] > > > > > > > > I'm thinking we should probably have a generic compatible entry as well, > > > > "qcom,pmic-qpnp" or similar. We should still specify in the binding > > > > that PMIC slaves specify a version-specific string as

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-05-09 Thread Ivan T. Ivanov
Hi, On Thu, 2014-04-24 at 13:18 -0500, Josh Cartwright wrote: > On Wed, Apr 23, 2014 at 04:36:22PM -0700, Courtney Cavin wrote: > > On Wed, Apr 23, 2014 at 11:46:26PM +0200, Josh Cartwright wrote: > > > On Tue, Apr 22, 2014 at 05:31:49PM -0700, Courtney Cavin wrote: > [..] > > $ git gre

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-05-07 Thread Rob Herring
On Wed, Apr 23, 2014 at 8:19 AM, Ivan T. Ivanov wrote: > > Hi, > > On Tue, 2014-04-22 at 17:31 -0700, Courtney Cavin wrote: >> From: Josh Cartwright >> >> The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon >> 800 series SoC family. This driver exists largely as a glue mfd c

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-28 Thread Ivan T. Ivanov
Hi Frank, On Fri, 2014-04-25 at 17:28 -0700, Frank Rowand wrote: > On 4/23/2014 6:19 AM, Ivan T. Ivanov wrote: > > spmi { > > compatible = "qcom,spmi-pmic-arb"; > > reg-names = "core", "intr", "cnfg"; > > reg = <0xfc4cf000 0x1000>, > > <0xfc4cb000 0x1000>, > > <

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-25 Thread David Collins
On 04/23/2014 04:36 PM, Courtney Cavin wrote: > On Wed, Apr 23, 2014 at 11:46:26PM +0200, Josh Cartwright wrote: >> On Tue, Apr 22, 2014 at 05:31:49PM -0700, Courtney Cavin wrote: [..] >>> +++ b/drivers/mfd/pm8x41.c >>> @@ -0,0 +1,63 @@ >>> +/* Copyright (c) 2013, The Linux Foundation. All rights r

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-25 Thread Frank Rowand
On 4/25/2014 5:40 PM, Courtney Cavin wrote: > On Sat, Apr 26, 2014 at 02:28:06AM +0200, Frank Rowand wrote: >> On 4/23/2014 6:19 AM, Ivan T. Ivanov wrote: > [...] +static int pm8x41_probe(struct spmi_device *sdev) +{ + struct regmap *regmap; + + regmap = devm_regmap_init_

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-25 Thread Courtney Cavin
On Sat, Apr 26, 2014 at 02:28:06AM +0200, Frank Rowand wrote: > On 4/23/2014 6:19 AM, Ivan T. Ivanov wrote: [...] > >> +static int pm8x41_probe(struct spmi_device *sdev) > >> +{ > >> + struct regmap *regmap; > >> + > >> + regmap = devm_regmap_init_spmi_ext(sdev, &pm8x41_regmap_config); > >> + if

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-25 Thread Frank Rowand
On 4/23/2014 6:19 AM, Ivan T. Ivanov wrote: > > Hi, > > On Tue, 2014-04-22 at 17:31 -0700, Courtney Cavin wrote: >> From: Josh Cartwright >> >> The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon >> 800 series SoC family. This driver exists largely as a glue mfd component,

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-24 Thread Josh Cartwright
On Wed, Apr 23, 2014 at 04:36:22PM -0700, Courtney Cavin wrote: > On Wed, Apr 23, 2014 at 11:46:26PM +0200, Josh Cartwright wrote: > > On Tue, Apr 22, 2014 at 05:31:49PM -0700, Courtney Cavin wrote: [..] > > One thing that I had meant to do is rename this thing. Nothing about > > this is PM8841/PM

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-23 Thread Rob Herring
On Wed, Apr 23, 2014 at 8:19 AM, Ivan T. Ivanov wrote: > > Hi, > > On Tue, 2014-04-22 at 17:31 -0700, Courtney Cavin wrote: >> From: Josh Cartwright >> >> The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon >> 800 series SoC family. This driver exists largely as a glue mfd c

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-23 Thread Courtney Cavin
On Wed, Apr 23, 2014 at 11:46:26PM +0200, Josh Cartwright wrote: > On Tue, Apr 22, 2014 at 05:31:49PM -0700, Courtney Cavin wrote: > > From: Josh Cartwright > > > > The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon > > 800 series SoC family. This driver exists largely as a

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-23 Thread Courtney Cavin
On Wed, Apr 23, 2014 at 10:34:32PM +0200, Ivan T. Ivanov wrote: > > On Wed, 2014-04-23 at 11:16 -0700, Courtney Cavin wrote: > > On Wed, Apr 23, 2014 at 03:19:28PM +0200, Ivan T. Ivanov wrote: > > > > > > Hi, > > > > > > On Tue, 2014-04-22 at 17:31 -0700, Courtney Cavin wrote: > > > > From: Josh

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-23 Thread Josh Cartwright
On Tue, Apr 22, 2014 at 05:31:49PM -0700, Courtney Cavin wrote: > From: Josh Cartwright > > The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon > 800 series SoC family. This driver exists largely as a glue mfd component, > it exists to be an owner of an SPMI regmap for child

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-23 Thread Ivan T. Ivanov
On Wed, 2014-04-23 at 11:16 -0700, Courtney Cavin wrote: > On Wed, Apr 23, 2014 at 03:19:28PM +0200, Ivan T. Ivanov wrote: > > > > Hi, > > > > On Tue, 2014-04-22 at 17:31 -0700, Courtney Cavin wrote: > > > From: Josh Cartwright > > > > > > The Qualcomm 8941 and 8841 PMICs are components used w

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-23 Thread Courtney Cavin
On Wed, Apr 23, 2014 at 03:19:28PM +0200, Ivan T. Ivanov wrote: > > Hi, > > On Tue, 2014-04-22 at 17:31 -0700, Courtney Cavin wrote: > > From: Josh Cartwright > > > > The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon > > 800 series SoC family. This driver exists largely

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-23 Thread Courtney Cavin
On Wed, Apr 23, 2014 at 12:50:55PM +0200, Lee Jones wrote: > > From: Josh Cartwright > > > > The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon > > 800 series SoC family. This driver exists largely as a glue mfd component, > > it exists to be an owner of an SPMI regmap for

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-23 Thread Ivan T. Ivanov
Hi, On Tue, 2014-04-22 at 17:31 -0700, Courtney Cavin wrote: > From: Josh Cartwright > > The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon > 800 series SoC family. This driver exists largely as a glue mfd component, > it exists to be an owner of an SPMI regmap for childr

Re: [PATCH 1/2] mfd: pm8x41: add support for Qualcomm 8x41 PMICs

2014-04-23 Thread Lee Jones
> From: Josh Cartwright > > The Qualcomm 8941 and 8841 PMICs are components used with the Snapdragon > 800 series SoC family. This driver exists largely as a glue mfd component, > it exists to be an owner of an SPMI regmap for children devices > described in device tree. > > Signed-off-by: Josh