Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

2013-07-29 Thread Philipp Zabel
Hi Lee, Am Montag, den 29.07.2013, 16:46 +0100 schrieb Lee Jones: > > > > > Signed-off-by: Krystian Garbaciak > > > > > Signed-off-by: Philipp Zabel > > > > > --- > > > > > drivers/mfd/Kconfig | 12 + > > > > > drivers/mfd/Makefile |3 + > > > > > drivers/

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

2013-07-29 Thread Samuel Ortiz
Hi Lee, On Mon, Jul 29, 2013 at 04:46:14PM +0100, Lee Jones wrote: > > > > > Signed-off-by: Krystian Garbaciak > > > > > Signed-off-by: Philipp Zabel > > > > > --- > > > > > drivers/mfd/Kconfig | 12 + > > > > > drivers/mfd/Makefile |3 + > > > > > drivers

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

2013-07-29 Thread Lee Jones
> > > > Signed-off-by: Krystian Garbaciak > > > > Signed-off-by: Philipp Zabel > > > > --- > > > > drivers/mfd/Kconfig | 12 + > > > > drivers/mfd/Makefile |3 + > > > > drivers/mfd/da9063-core.c| 177 ++ > > > > drivers/mfd/da9063-i2c.c

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

2013-07-25 Thread Mark Brown
On Thu, Jul 25, 2013 at 07:34:53PM +0200, Philipp Zabel wrote: > Well, most of those lines consist of the register and bit(field) > definitions and the assignment of those to regmap and regmap-irq. > I could split this into (core+i2c) and (irq) parts if you insist. You could probably put the reg

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

2013-07-25 Thread Philipp Zabel
Hi Lee, Am Donnerstag, den 25.07.2013, 09:08 +0100 schrieb Lee Jones: > > > Signed-off-by: Krystian Garbaciak > > > Signed-off-by: Philipp Zabel > > > --- > > > drivers/mfd/Kconfig | 12 + > > > drivers/mfd/Makefile |3 + > > > drivers/mfd/da9063-core.c

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

2013-07-25 Thread Philipp Zabel
Am Mittwoch, den 24.07.2013, 18:07 +0100 schrieb Mark Brown: > On Wed, Jul 24, 2013 at 06:34:42PM +0200, Philipp Zabel wrote: > > > + ret = regmap_read(da9063->regmap, DA9063_REG_CHIP_ID, &model); > > + if (ret < 0) { > > + dev_err(da9063->dev, "Cannot read chip model id.\n"); > > +

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

2013-07-25 Thread Lee Jones
> > Signed-off-by: Krystian Garbaciak > > Signed-off-by: Philipp Zabel > > --- > > drivers/mfd/Kconfig | 12 + > > drivers/mfd/Makefile |3 + > > drivers/mfd/da9063-core.c| 177 ++ > > drivers/mfd/da9063-i2c.c | 197 ++ > >

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

2013-07-25 Thread Lee Jones
On Wed, 24 Jul 2013, Philipp Zabel wrote: > From: Krystian Garbaciak > > This is MFD module providing access to registers and interrupts of DA906x > series PMIC. It is used by other functional modules, registered as MFD cells. > Driver uses regmap with paging to access extended register list. Re

Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.

2013-07-24 Thread Mark Brown
On Wed, Jul 24, 2013 at 06:34:42PM +0200, Philipp Zabel wrote: > + ret = regmap_read(da9063->regmap, DA9063_REG_CHIP_ID, &model); > + if (ret < 0) { > + dev_err(da9063->dev, "Cannot read chip model id.\n"); > + return -EIO; > + } > + > + ret = regmap_read(da