Re: [PATCH 1/2] leds: Add flag to keep trigger always

2019-10-09 Thread Guru Das Srinagesh
On Tue, Oct 08, 2019 at 09:47:31AM +0200, Pavel Machek wrote: > Hi! > > > > > > I don't understand. The original commit broke userspace operations. > > > > > Shouldn't it be reverted, or fixed this way in order to have userspace > > > > > work properly again? > > > > > > > > So, what it is exact

Re: [PATCH 1/2] leds: Add flag to keep trigger always

2019-10-08 Thread Pavel Machek
Hi! > > > > I don't understand. The original commit broke userspace operations. > > > > Shouldn't it be reverted, or fixed this way in order to have userspace > > > > work properly again? > > > > > > So, what it is exactly that is not working? :-). Yes, root can > > > disconnect LED from v4l2 in

Re: [PATCH 1/2] leds: Add flag to keep trigger always

2019-10-04 Thread Guru Das Srinagesh
On Mon, Sep 30, 2019 at 07:27:43PM +0200, Greg KH wrote: > On Mon, Sep 30, 2019 at 07:22:39PM +0200, Pavel Machek wrote: > > On Mon 2019-09-30 15:39:02, Greg KH wrote: > > > On Sat, Aug 10, 2019 at 09:13:22AM +0200, Pavel Machek wrote: > > > > On Fri 2019-08-09 17:52:46, Guru Das Srinagesh wrote: >

Re: [PATCH 1/2] leds: Add flag to keep trigger always

2019-09-30 Thread Greg KH
On Mon, Sep 30, 2019 at 07:22:39PM +0200, Pavel Machek wrote: > On Mon 2019-09-30 15:39:02, Greg KH wrote: > > On Sat, Aug 10, 2019 at 09:13:22AM +0200, Pavel Machek wrote: > > > On Fri 2019-08-09 17:52:46, Guru Das Srinagesh wrote: > > > > From: Subbaraman Narayanamurthy > > > > > > > > Commit 0

Re: [PATCH 1/2] leds: Add flag to keep trigger always

2019-09-30 Thread Pavel Machek
On Mon 2019-09-30 15:39:02, Greg KH wrote: > On Sat, Aug 10, 2019 at 09:13:22AM +0200, Pavel Machek wrote: > > On Fri 2019-08-09 17:52:46, Guru Das Srinagesh wrote: > > > From: Subbaraman Narayanamurthy > > > > > > Commit 0013b23d66a2768f5babbb0ea9f03ab067a990d8 ("leds: disable triggers > > > on

Re: [PATCH 1/2] leds: Add flag to keep trigger always

2019-09-30 Thread Greg KH
On Sat, Aug 10, 2019 at 09:13:22AM +0200, Pavel Machek wrote: > On Fri 2019-08-09 17:52:46, Guru Das Srinagesh wrote: > > From: Subbaraman Narayanamurthy > > > > Commit 0013b23d66a2768f5babbb0ea9f03ab067a990d8 ("leds: disable triggers > > on brightness set") removes the trigger on an LED class de

Re: [PATCH 1/2] leds: Add flag to keep trigger always

2019-08-10 Thread Pavel Machek
On Fri 2019-08-09 17:52:46, Guru Das Srinagesh wrote: > From: Subbaraman Narayanamurthy > > Commit 0013b23d66a2768f5babbb0ea9f03ab067a990d8 ("leds: disable triggers > on brightness set") removes the trigger on an LED class device when > brightness is set to 0. However, there are some LED class de